sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

superio: Drop print_ implementation from non-romcc boards

Browse Source 
Because we had no stack on romcc boards, we had a separate, not as
powerful clone of printk: print_*. Back in the day, like more than
half a decade ago, we migrated a lot of boards to printk, but we never
cleaned up the existing code to be consistent. instead, we worked around
the problem with a very messy console.h (nowadays the mess is hidden in
romstage_console.c and early_print.h)
This patch cleans up the superio code to use printk() on all non-ROMCC
boards.

Change-Id: I23fc307f1346cdb7adaaeccfafe17d9205e909ac
Signed-off-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Reviewed-on: http://review.coreboot.org/8113
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Tested-by: build bot (Jenkins)
This commit is contained in:
Stefan Reinauer
2015-01-05 13:05:44 -08:00
committed by Stefan Reinauer
parent 0d3cde9062
commit d42c9dae85
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/superio/serverengines/pilot/early_init.c
View File

@@ -36,11 +36,9 @@ void pilot_early_init(pnp_devfn_t dev)
{ {
u16 port = dev >> 8; u16 port = dev >> 8;
print_debug("Using port: "); printk(BIOS_DEBUG, "Using port: %04x\n", port);
print_debug_hex16(port);
print_debug("\n");
pilot_disable_serial(PNP_DEV(port, 0x1)); pilot_disable_serial(PNP_DEV(port, 0x1));
print_debug("disable serial 1\n"); printk(BIOS_DEBUG, "disable serial 1\n");
pnp_enter_ext_func_mode(dev); pnp_enter_ext_func_mode(dev);
pnp_set_logical_device(PNP_DEV(port, 0x3)); pnp_set_logical_device(PNP_DEV(port, 0x3));