Move compiler.h to commonlib

Its spreading copies got out of sync. And as it is not a standard header
but used in commonlib code, it belongs into commonlib. While we are at
it, always include it via GCC's `-include` switch.

Some Windows and BSD quirk handling went into the util copies. We always
guard from redefinitions now to prevent further issues.

Change-Id: I850414e6db1d799dce71ff2dc044e6a000ad2552
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/28927
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>

src/drivers/amd/agesa/romstage.c

@@ -18,7 +18,6 @@
 #include <cbmem.h>
 #include <cpu/amd/car.h>
 #include <cpu/x86/bist.h>
-#include <compiler.h>
 #include <console/console.h>
 #include <halt.h>
 #include <program_loading.h>

src/drivers/amd/agesa/state_machine.c

@@ -21,7 +21,6 @@
 #include <bootstate.h>
 #include <cbfs.h>
 #include <cbmem.h>
-#include <compiler.h>
 
 #include <northbridge/amd/agesa/state_machine.h>
 #include <northbridge/amd/agesa/agesa_helper.h>

src/drivers/elog/boot_count.c

@@ -18,7 +18,6 @@
 #include <pc80/mc146818rtc.h>
 #include <stddef.h>
 #include <stdint.h>
-#include <compiler.h>
 #include <elog.h>
 
 /*

src/drivers/elog/elog_internal.h

@@ -16,7 +16,6 @@
 #ifndef ELOG_INTERNAL_H_
 #define ELOG_INTERNAL_H_
 
-#include <compiler.h>
 /* ELOG header */
 struct elog_header {
 	u32 magic;

src/drivers/elog/gsmi.c

@@ -13,9 +13,7 @@
  * GNU General Public License for more details.
  */
 
-#include <compiler.h>
 #include <arch/io.h>
-#include <compiler.h>
 #include <console/console.h>
 #include <cpu/x86/smm.h>
 #include <elog.h>

src/drivers/i2c/designware/dw_i2c.h

@@ -16,7 +16,6 @@
 #ifndef __DRIVERS_I2C_DESIGNWARE_I2C_H__
 #define __DRIVERS_I2C_DESIGNWARE_I2C_H__
 
-#include <compiler.h>
 #include <device/device.h>
 #include <device/i2c.h>
 #include <stdint.h>

src/drivers/i2c/tpm/cr50.c

@@ -31,7 +31,6 @@
 
 #include <arch/early_variables.h>
 #include <commonlib/endian.h>
-#include <compiler.h>
 #include <stdint.h>
 #include <string.h>
 #include <types.h>

src/drivers/i2c/tpm/tis_atmel.c

@@ -14,7 +14,6 @@
 
 #include <arch/early_variables.h>
 #include <stdint.h>
-#include <compiler.h>
 #include <string.h>
 #include <assert.h>
 #include <commonlib/endian.h>

src/drivers/intel/fsp1_0/fsp_util.c

@@ -15,7 +15,6 @@
 
 #include <types.h>
 #include <string.h>
-#include <compiler.h>
 #include <console/console.h>
 #include <bootstate.h>
 #include <cbmem.h>

src/drivers/intel/fsp1_0/fsp_util.h

@@ -16,7 +16,6 @@
 #ifndef FSP_UTIL_H
 #define FSP_UTIL_H
 
-#include <compiler.h>
 #include <chipset_fsp_util.h>
 #include "fsp_values.h"
 

src/drivers/intel/fsp1_1/car.c

@@ -14,7 +14,6 @@
  */
 
 #include <arch/early_variables.h>
-#include <compiler.h>
 #include <console/console.h>
 #include <fsp/car.h>
 #include <fsp/util.h>

src/drivers/intel/fsp1_1/fsp_util.c

@@ -14,7 +14,6 @@
  * GNU General Public License for more details.
  */
 
-#include <compiler.h>
 #include <bootstate.h>
 #include <cbmem.h>
 #include <console/console.h>

src/drivers/intel/fsp1_1/raminit.c

@@ -15,7 +15,6 @@
 
 #include <arch/acpi.h>
 #include <cbmem.h>
-#include <compiler.h>
 #include <console/console.h>
 #include <fsp/memmap.h>
 #include <fsp/romstage.h>

src/drivers/intel/fsp1_1/ramstage.c

@@ -18,7 +18,6 @@
 #include <arch/acpi.h>
 #include <cbmem.h>
 #include <cbfs.h>
-#include <compiler.h>
 #include <console/console.h>
 #include <fsp/memmap.h>
 #include <fsp/ramstage.h>

src/drivers/intel/fsp1_1/romstage.c

@@ -20,7 +20,6 @@
 #include <arch/cbfs.h>
 #include <arch/early_variables.h>
 #include <assert.h>
-#include <compiler.h>
 #include <console/console.h>
 #include <cbmem.h>
 #include <cpu/intel/microcode.h>

src/drivers/intel/fsp2_0/graphics.c

@@ -10,7 +10,6 @@
  * (at your option) any later version.
  */
 
-#include <compiler.h>
 #include <cbfs.h>
 #include <console/console.h>
 #include <fsp/util.h>

src/drivers/intel/fsp2_0/hob_display.c

@@ -9,7 +9,6 @@
  * (at your option) any later version.
  */
 
-#include <compiler.h>
 #include <console/console.h>
 #include <fsp/util.h>
 

src/drivers/intel/fsp2_0/include/fsp/upd.h

@@ -12,8 +12,6 @@
 #ifndef _FSP2_0_UPD_H_
 #define _FSP2_0_UPD_H_
 
-#include <compiler.h>
-
 struct FSP_UPD_HEADER {
 	///
 	/// UPD Region Signature. This signature will be

src/drivers/intel/fsp2_0/include/fsp/util.h

@@ -13,7 +13,6 @@
 #ifndef _FSP2_0_UTIL_H_
 #define _FSP2_0_UTIL_H_
 
-#include <compiler.h>
 #include <boot/coreboot_tables.h>
 #include <commonlib/region.h>
 #include <arch/cpu.h>

src/drivers/intel/fsp2_0/memory_init.c

@@ -11,7 +11,6 @@
  * (at your option) any later version.
  */
 
-#include <compiler.h>
 #include <security/vboot/antirollback.h>
 #include <arch/io.h>
 #include <arch/cpu.h>

src/drivers/intel/fsp2_0/notify.c

@@ -12,7 +12,6 @@
 
 #include <arch/cpu.h>
 #include <bootstate.h>
-#include <compiler.h>
 #include <console/console.h>
 #include <fsp/util.h>
 #include <soc/intel/common/util.h>

src/drivers/intel/fsp2_0/upd_display.c

@@ -10,7 +10,6 @@
  */
 
 #include <arch/cpu.h>
-#include <compiler.h>
 #include <console/console.h>
 #include <fsp/util.h>
 #include <lib.h>

src/drivers/intel/gma/intel_bios.h

@@ -28,8 +28,6 @@
 #ifndef _I830_BIOS_H_
 #define _I830_BIOS_H_
 
-#include <compiler.h>
-
 struct vbt_header {
 	u8 signature[20];		/**< Always starts with 'VBT$' */
 	u16 version;			/**< decimal */

src/drivers/intel/gma/opregion.h

@@ -19,7 +19,6 @@
 #define _COMMON_GMA_H_
 
 #include <types.h>
-#include <compiler.h>
 #include <commonlib/helpers.h>
 
 /* IGD PCI Configuration register */

src/drivers/intel/mipi_camera/chip.h

@@ -17,7 +17,6 @@
 #define __INTEL_MIPI_CAMERA_CHIP_H__
 
 #include <stdint.h>
-#include <compiler.h>
 
 #define MAX_PWDB_ENTRIES 12
 

src/drivers/intel/wifi/wifi.c

@@ -15,7 +15,6 @@
  * GNU General Public License for more details.
  */
 
-#include <compiler.h>
 #include <arch/acpi_device.h>
 #include <arch/acpigen.h>
 #include <console/console.h>

src/drivers/mrc_cache/mrc_cache.c

@@ -13,7 +13,6 @@
  * GNU General Public License for more details.
  */
 
-#include <compiler.h>
 #include <string.h>
 #include <boot_device.h>
 #include <bootstate.h>

src/drivers/siemens/nc_fpga/nc_fpga.h

@@ -16,8 +16,6 @@
 #ifndef _SIEMENS_NC_FPGA_H_
 #define _SIEMENS_NC_FPGA_H_
 
-#include <compiler.h>
-
 #define NC_MAGIC_OFFSET			0x020
 #define  NC_FPGA_MAGIC			0x4E433746
 #define NC_CAP1_OFFSET			0x080

src/drivers/spi/spi-generic.c

@@ -15,7 +15,6 @@
  */
 
 #include <assert.h>
-#include <compiler.h>
 #include <spi-generic.h>
 #include <string.h>
 

src/drivers/spi/tpm/tpm.c

@@ -17,7 +17,6 @@
 
 #include <arch/early_variables.h>
 #include <assert.h>
-#include <compiler.h>
 #include <commonlib/endian.h>
 #include <console/console.h>
 #include <delay.h>

src/drivers/usb/ehci.h

@@ -19,8 +19,6 @@
 #ifndef EHCI_H
 #define EHCI_H
 
-#include <compiler.h>
-
 /* EHCI register interface, corresponds to EHCI Revision 0.95 specification */
 
 /* Section 2.2 Host Controller Capability Registers */

src/drivers/usb/usb_ch9.h

@@ -17,8 +17,6 @@
 #ifndef USB_CH9_H
 #define USB_CH9_H
 
-#include <compiler.h>
-
 #define USB_DIR_OUT                     0               /* to device */
 #define USB_DIR_IN                      0x80            /* to host */
 

src/drivers/vpd/vpd_tables.h

@@ -9,7 +9,6 @@
 #ifndef __LIB_VPD_TABLES_H__
 #define __LIB_VPD_TABLES_H__
 
-#include <compiler.h>
 #include <inttypes.h>
 
 #define VPD_ENTRY_MAGIC    "_SM_"