Move compiler.h to commonlib

Its spreading copies got out of sync. And as it is not a standard header
but used in commonlib code, it belongs into commonlib. While we are at
it, always include it via GCC's `-include` switch.

Some Windows and BSD quirk handling went into the util copies. We always
guard from redefinitions now to prevent further issues.

Change-Id: I850414e6db1d799dce71ff2dc044e6a000ad2552
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/28927
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>

src/include/compiler.h

@@ -1,32 +0,0 @@
-/*
- * This file is part of the coreboot project.
- *
- * Copyright 2017 Google Inc.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; version 2 of the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- */
-
-#ifndef __COMPILER_H__
-#define __COMPILER_H__
-
-#if defined(__WIN32) || defined(__WIN64)
-#define __packed __attribute__((gcc_struct, packed))
-#else
-#define __packed __attribute__((packed))
-#endif
-
-#define __aligned(x) __attribute__((aligned(x)))
-#define __always_unused __attribute__((unused))
-#define __must_check __attribute__((warn_unused_result))
-#define __weak __attribute__((weak))
-#define __noreturn __attribute__((noreturn))
-#define __always_inline inline __attribute__((always_inline))
-
-#endif

src/include/console/console.h

@@ -19,7 +19,6 @@
 #include <stdint.h>
 #include <rules.h>
 #include <arch/cpu.h>
-#include <compiler.h>
 #include <console/post_codes.h>
 #include <commonlib/loglevel.h>
 

src/include/console/spi.h

@@ -18,7 +18,6 @@
 
 #include <rules.h>
 #include <stdint.h>
-#include <compiler.h>
 
 void spiconsole_init(void);
 void spiconsole_tx_byte(unsigned char c);

src/include/cpu/amd/mtrr.h

@@ -38,7 +38,6 @@
 
 #if !defined(__PRE_RAM__) && !defined(__ASSEMBLER__)
 
-#include <compiler.h>
 #include <cpu/x86/msr.h>
 
 void amd_setup_mtrrs(void);

src/include/cpu/x86/cache.h

@@ -16,7 +16,6 @@
 #ifndef CPU_X86_CACHE
 #define CPU_X86_CACHE
 
-#include <compiler.h>
 #include <cpu/x86/cr.h>
 
 #define CR0_CacheDisable	(CR0_CD)

src/include/cpu/x86/cr.h

@@ -18,7 +18,6 @@
 
 #if !defined(__ASSEMBLER__)
 
-#include <compiler.h>
 #include <stdint.h>
 #include <arch/cpu.h>
 

src/include/cpu/x86/lapic.h

@@ -1,7 +1,6 @@
 #ifndef CPU_X86_LAPIC_H
 #define CPU_X86_LAPIC_H
 
-#include <compiler.h>
 #include <cpu/x86/lapic_def.h>
 #include <cpu/x86/msr.h>
 #include <halt.h>

src/include/cpu/x86/msr.h

@@ -1,8 +1,6 @@
 #ifndef CPU_X86_MSR_H
 #define CPU_X86_MSR_H
 
-#include <compiler.h>
-
 /* Intel SDM: Table 2-1
  * IA-32 architectural MSR: Extended Feature Enable Register
  */

src/include/cpu/x86/smm.h

@@ -22,7 +22,6 @@
 
 #include <arch/cpu.h>
 #include <types.h>
-#include <compiler.h>
 
 #define SMM_DEFAULT_BASE 0x30000
 #define SMM_DEFAULT_SIZE 0x10000

src/include/device/pci_ops.h

@@ -1,7 +1,6 @@
 #ifndef PCI_OPS_H
 #define PCI_OPS_H
 
-#include <compiler.h>
 #include <stdint.h>
 #include <device/device.h>
 #include <arch/pci_ops.h>

src/include/elog.h

@@ -16,8 +16,6 @@
 #ifndef ELOG_H_
 #define ELOG_H_
 
-#include <compiler.h>
-
 /* SMI command code for GSMI event logging */
 #define ELOG_GSMI_APM_CNT                 0xEF
 

src/include/halt.h

@@ -20,7 +20,6 @@
 #ifdef __ROMCC__
 #include <lib/halt.c>
 #else
-#include <compiler.h>
 /**
  * halt the system reliably
  */

src/include/memory_info.h

@@ -17,7 +17,6 @@
 #define _MEMORY_INFO_H_
 
 #include <stdint.h>
-#include <compiler.h>
 
 #define DIMM_INFO_SERIAL_SIZE		4
 #define DIMM_INFO_PART_NUMBER_SIZE	21

src/include/reset.h

@@ -1,8 +1,6 @@
 #ifndef RESET_H
 #define RESET_H
 
-#include <compiler.h>
-
 /* Generic reset functions. Call from code that wants to trigger a reset. */
 
 /* Super-hard reset specific to some Intel SoCs. */

src/include/sar.h

@@ -15,7 +15,6 @@
 #ifndef _SAR_H_
 #define _SAR_H_
 
-#include <compiler.h>
 #include <stdint.h>
 
 #define NUM_SAR_LIMITS 4

src/include/smbios.h

@@ -19,7 +19,6 @@
 #define SMBIOS_H
 
 #include <types.h>
-#include <compiler.h>
 
 unsigned long smbios_write_tables(unsigned long start);
 int smbios_add_string(u8 *start, const char *str);

src/include/vbe.h

@@ -13,7 +13,6 @@
 #ifndef VBE_H
 #define VBE_H
 
-#include <compiler.h>
 #include <boot/coreboot_tables.h>
 // these structs are for input from and output to OF
 typedef struct {