soc/intel/{skl,cnl}: Guard USB macro parameters
Add parentheses around the parameter of the `USB_PORT_WAKE_ENABLE` macro to prevent unintentional operator precedence problems. Change-Id: I61fbacc129cbfb42ade7e64ee40cd07c98d87683 Signed-off-by: Angel Pons <th3fanbus@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60324 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org> Reviewed-by: Felix Singer <felixsinger@posteo.net>
This commit is contained in:
		@@ -191,6 +191,6 @@ struct usb3_port_config {
 | 
			
		||||
 * to Port 1, Bit n corresponds to Port (n+1). This bitmap is later used to
 | 
			
		||||
 * decide what ports need to set PORTSCN/PORTSCXUSB3 register bits.
 | 
			
		||||
 */
 | 
			
		||||
#define USB_PORT_WAKE_ENABLE(x)		(1 << (x - 1))
 | 
			
		||||
#define USB_PORT_WAKE_ENABLE(x)		(1 << ((x) - 1))
 | 
			
		||||
 | 
			
		||||
#endif
 | 
			
		||||
 
 | 
			
		||||
@@ -185,6 +185,6 @@ struct usb3_port_config {
 | 
			
		||||
 * to Port 1, Bit n corresponds to Port (n+1). This bitmap is later used to
 | 
			
		||||
 * decide what ports need to set PORTSCN/PORTSCXUSB3 register bits.
 | 
			
		||||
 */
 | 
			
		||||
#define USB_PORT_WAKE_ENABLE(x)		(1 << (x - 1))
 | 
			
		||||
#define USB_PORT_WAKE_ENABLE(x)		(1 << ((x) - 1))
 | 
			
		||||
 | 
			
		||||
#endif
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user