zero warnings days.
The tyan s2895 is down to 3 warnings, 2 of which are caused by #warning. The 1000 ways of how the AMD code waits for the cores to be started up are a real pain for the brain. Signed-off-by: Stefan Reinauer <stepan@coresystems.de> Acked-by: Stefan Reinauer <stepan@coresystems.de> git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5396 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
This commit is contained in:
committed by
Stefan Reinauer
parent
f358c0c555
commit
d4f53738e6
@@ -7,6 +7,7 @@
|
||||
#include <cpu/x86/cache.h>
|
||||
#include <cpu/x86/mtrr.h>
|
||||
#include <stdlib.h>
|
||||
#include <reset.h>
|
||||
#include "raminit.h"
|
||||
#include "amdk8.h"
|
||||
|
||||
@@ -564,11 +565,13 @@ static int is_dual_channel(const struct mem_controller *ctrl)
|
||||
|
||||
static int is_opteron(const struct mem_controller *ctrl)
|
||||
{
|
||||
/* Test to see if I am an Opteron.
|
||||
* FIXME Socket 939 based Athlon64 have dual channel capability,
|
||||
* too, so we need a better test for Opterons
|
||||
/* Test to see if I am an Opteron. Socket 939 based Athlon64
|
||||
* have dual channel capability, too, so we need a better test
|
||||
* for Opterons.
|
||||
* However, all code uses is_opteron() to find out whether to
|
||||
* use dual channel, so if we really check for opteron here, we
|
||||
* need to fix up all code using this function, too.
|
||||
*/
|
||||
#warning "FIXME: Implement a better test for Opterons"
|
||||
uint32_t nbcap;
|
||||
nbcap = pci_read_config32(ctrl->f3, NORTHBRIDGE_CAP);
|
||||
return !!(nbcap & NBCAP_128Bit);
|
||||
|
Reference in New Issue
Block a user