From d6b34b39f80e53786d8f4403bbc7d5805f6f0a7d Mon Sep 17 00:00:00 2001 From: Zanxi Chen Date: Mon, 21 Jun 2021 16:54:11 +0800 Subject: [PATCH] mb/google/dedede/var/blipper: Enable ELAN touchscreen Modify driver from hid to generic(ELAN0001 that used generic driver without hid). BUG=b:191620724 BRANCH=dedede TEST=build bios and boot, touchscreen will work properly. Change-Id: Ife77d514d9906049f237edd169bc07bb53c48579 Signed-off-by: Zanxi Chen Reviewed-on: https://review.coreboot.org/c/coreboot/+/55718 Tested-by: build bot (Jenkins) Reviewed-by: Karthik Ramasubramanian Reviewed-by: Tao Xia --- .../dedede/variants/blipper/overridetree.cb | 29 +++++++++---------- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/src/mainboard/google/dedede/variants/blipper/overridetree.cb b/src/mainboard/google/dedede/variants/blipper/overridetree.cb index 280ed5d71d..48dd2e77ff 100644 --- a/src/mainboard/google/dedede/variants/blipper/overridetree.cb +++ b/src/mainboard/google/dedede/variants/blipper/overridetree.cb @@ -134,24 +134,23 @@ chip soc/intel/jasperlake register "hid_desc_reg_offset" = "0x01" device i2c 0x40 on end end - chip drivers/i2c/hid - register "generic.hid" = ""ELAN0001"" - register "generic.desc" = ""ELAN Touchscreen"" - register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_D4_IRQ)" - register "generic.probed" = "1" - register "generic.reset_gpio" = + chip drivers/i2c/generic + register "hid" = ""ELAN0001"" + register "desc" = ""ELAN Touchscreen"" + register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_D4_IRQ)" + register "probed" = "1" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D5)" - register "generic.reset_delay_ms" = "20" - register "generic.reset_off_delay_ms" = "2" - register "generic.stop_gpio" = + register "reset_delay_ms" = "20" + register "reset_off_delay_ms" = "2" + register "stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A11)" - register "generic.stop_delay_ms" = "280" - register "generic.stop_off_delay_ms" = "2" - register "generic.enable_gpio" = + register "stop_delay_ms" = "280" + register "stop_off_delay_ms" = "2" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D6)" - register "generic.enable_delay_ms" = "1" - register "generic.has_power_resource" = "1" - register "hid_desc_reg_offset" = "0x01" + register "enable_delay_ms" = "1" + register "has_power_resource" = "1" device i2c 10 on end end end # I2C 2