sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nb/intel/sandybridge/raminit: Drop write to BANDTIMERS_SNB

Browse Source 
MRC.bin doesn't write BANDTIMERS_SNB register, so drop the
write. The bits written were targeting a reserved range,
so assume it didn't do anything useful.

Tested on Lenovo X220: Still boots and runs fine.

Change-Id: I920aabd60831c791188af976914553787cc0ff18
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/79760
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
This commit is contained in:
Patrick Rudolph 2023-12-21 14:46:48 +01:00 committed by Felix Held
parent 8204dc395e
commit d81324eb74
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/northbridge/intel/sandybridge/raminit_common.c
View File

@ -2865,7 +2865,6 @@ void final_registers(ramctr_timing *ctrl)
mchbar_setbits32(MC_INIT_STATE_G, 1 << 0); mchbar_setbits32(MC_INIT_STATE_G, 1 << 0);
mchbar_setbits32(MC_INIT_STATE_G, 1 << 7); mchbar_setbits32(MC_INIT_STATE_G, 1 << 7);
mchbar_write32(BANDTIMERS_SNB, 0xfa);
/* Find a populated channel */ /* Find a populated channel */
FOR_ALL_POPULATED_CHANNELS FOR_ALL_POPULATED_CHANNELS