From da335abfe7b7aa097b7c12585cc2739087c87e9a Mon Sep 17 00:00:00 2001 From: Angel Pons Date: Fri, 2 Apr 2021 18:05:31 +0200 Subject: [PATCH] soc/ti/am335x/mmc.c: Fix memset length argument The sizeof() operator was being applied to a pointer-to-struct type. Correct this, so that the entire struct space gets cleared. Change-Id: Ieab3aaa2d07a928f27004b94132377d5dae935c0 Found-by: Coverity CID 1451732 Signed-off-by: Angel Pons Reviewed-on: https://review.coreboot.org/c/coreboot/+/52054 Reviewed-by: Nico Huber Reviewed-by: Arthur Heymans Reviewed-by: Sam Lewis Tested-by: build bot (Jenkins) --- src/soc/ti/am335x/mmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/soc/ti/am335x/mmc.c b/src/soc/ti/am335x/mmc.c index 395cf4fe0b..b7b4f97c70 100644 --- a/src/soc/ti/am335x/mmc.c +++ b/src/soc/ti/am335x/mmc.c @@ -260,7 +260,7 @@ int am335x_mmc_init_storage(struct am335x_mmc_host *mmc_host) int err = 0; struct sd_mmc_ctrlr *mmc_ctrlr = &mmc_host->sd_mmc_ctrlr; - memset(mmc_ctrlr, 0, sizeof(mmc_ctrlr)); + memset(mmc_ctrlr, 0, sizeof(*mmc_ctrlr)); err = am335x_mmc_init(mmc_host->reg);