sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

superio/nsc/pc87366: Use link-time symbols over .c inclusion

Browse Source 
Change-Id: Id156ca3c9a14c5bcc4d6cdb8434ca8efdac3139a
Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Reviewed-on: http://review.coreboot.org/8077
Tested-by: build bot (Jenkins)
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
This commit is contained in:
Edward O'Callaghan
2015-01-04 16:10:32 +11:00
parent fc4e8550af
commit db1a2fb3df
6 changed files with 14 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/mainboard/ibm/e325/romstage.c
View File

@ -13,7 +13,7 @@
#include "lib/delay.c" #include "lib/delay.c"
#include "northbridge/amd/amdk8/reset_test.c" #include "northbridge/amd/amdk8/reset_test.c"
#include "northbridge/amd/amdk8/debug.c" #include "northbridge/amd/amdk8/debug.c"
#include "superio/nsc/pc87366/early_serial.c" #include <superio/nsc/pc87366/pc87366.h>
#include "cpu/x86/bist.h" #include "cpu/x86/bist.h"
#include "northbridge/amd/amdk8/setup_resource_map.c" #include "northbridge/amd/amdk8/setup_resource_map.c"
#include <spd.h> #include <spd.h>

2
src/mainboard/ibm/e326/romstage.c
View File

@ -13,7 +13,7 @@
#include "lib/delay.c" #include "lib/delay.c"
#include "northbridge/amd/amdk8/reset_test.c" #include "northbridge/amd/amdk8/reset_test.c"
#include "northbridge/amd/amdk8/debug.c" #include "northbridge/amd/amdk8/debug.c"
#include "superio/nsc/pc87366/early_serial.c" #include <superio/nsc/pc87366/pc87366.h>
#include "cpu/x86/bist.h" #include "cpu/x86/bist.h"
#include "northbridge/amd/amdk8/setup_resource_map.c" #include "northbridge/amd/amdk8/setup_resource_map.c"
#include "southbridge/amd/amd8111/early_ctrl.c" #include "southbridge/amd/amd8111/early_ctrl.c"

1
src/superio/nsc/pc87366/Makefile.inc
View File

@ -19,4 +19,5 @@
## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
## ##
romstage-$(CONFIG_SUPERIO_NSC_PC87366) += early_serial.c
ramstage-$(CONFIG_SUPERIO_NSC_PC87366) += superio.c ramstage-$(CONFIG_SUPERIO_NSC_PC87366) += superio.c

4
src/superio/nsc/pc87366/early_serial.c
View File

@ -20,9 +20,11 @@
*/ */
#include <arch/io.h> #include <arch/io.h>
#include <device/pnp.h>
#include <stdint.h>
#include "pc87366.h" #include "pc87366.h"
static void pc87366_enable_serial(pnp_devfn_t dev, u16 iobase) void pc87366_enable_serial(pnp_devfn_t dev, u16 iobase)
{ {
pnp_set_logical_device(dev); pnp_set_logical_device(dev);
pnp_set_enable(dev, 0); pnp_set_enable(dev, 0);

11
src/superio/nsc/pc87366/pc87366.h
View File

@ -19,8 +19,8 @@
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
*/ */
#ifndef SUPERIO_NSC_PC87366_PC87366_H #ifndef SUPERIO_NSC_PC87366_H
#define SUPERIO_NSC_PC87366_PC87366_H #define SUPERIO_NSC_PC87366_H
#define PC87366_FDC 0x00 /* Floppy */ #define PC87366_FDC 0x00 /* Floppy */
#define PC87366_PP 0x01 /* Parallel port */ #define PC87366_PP 0x01 /* Parallel port */
@ -38,4 +38,9 @@
#define PC87366_VLM 0x0D #define PC87366_VLM 0x0D
#define PC87366_TMS 0x0E #define PC87366_TMS 0x0E
#endif #include <arch/io.h>
#include <stdint.h>
void pc87366_enable_serial(pnp_devfn_t dev, u16 iobase);
#endif /* SUPERIO_NSC_PC87366_H */

1
src/superio/nsc/pc87366/superio.c
View File

@ -30,7 +30,6 @@
static void init(struct device *dev) static void init(struct device *dev)
{ {
if (!dev->enabled) if (!dev->enabled)
return; return;