mb/google/cyan: Guard I2C devices as wake sources with CONFIG_CHROMEOS
The use of a separate _PRW is not necessary when the _CRS interrupt
already has the Wake flag set (as these all do). Additionally, Windows
does not allow the use of a gpioint for the _PRW source, which results
in an ACPI_BIOS_ERROR BSOD.
Since ChromeOS builds for CYAN devices use an older kernel and may not
make use of _CRS interrupt Wake flag, keep the _PRW around when
CONFIG_CHROMEOS is selected.
TEST=build/boot Win11 on google/{cyan,edgar}
Change-Id: I7d0883e4de9572a14c8bad0ac086370bd00eeb1a
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/76798
Reviewed-by: CoolStar <coolstarorganization@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
			
			
This commit is contained in:
		
				
					committed by
					
						
						Felix Held
					
				
			
			
				
	
			
			
			
						parent
						
							8757b23ae9
						
					
				
				
					commit
					db20a08b65
				
			@@ -35,9 +35,9 @@ Scope (\_SB.PCI0.I2C1)
 | 
				
			|||||||
				Return (0x0)
 | 
									Return (0x0)
 | 
				
			||||||
			}
 | 
								}
 | 
				
			||||||
		}
 | 
							}
 | 
				
			||||||
 | 
					#if CONFIG(CHROMEOS)
 | 
				
			||||||
		Name (_PRW, Package() { BOARD_TOUCHSCREEN_WAKE_GPIO, 0x3 })
 | 
							Name (_PRW, Package() { BOARD_TOUCHSCREEN_WAKE_GPIO, 0x3 })
 | 
				
			||||||
 | 
					#endif
 | 
				
			||||||
		/* Allow device to power off in S0 */
 | 
							/* Allow device to power off in S0 */
 | 
				
			||||||
		Name (_S0W, 4)
 | 
							Name (_S0W, 4)
 | 
				
			||||||
	}
 | 
						}
 | 
				
			||||||
 
 | 
				
			|||||||
@@ -34,9 +34,9 @@ Scope (\_SB.PCI0.I2C1)
 | 
				
			|||||||
				Return (0x0)
 | 
									Return (0x0)
 | 
				
			||||||
			}
 | 
								}
 | 
				
			||||||
		}
 | 
							}
 | 
				
			||||||
 | 
					#if CONFIG(CHROMEOS)
 | 
				
			||||||
		Name (_PRW, Package() { BOARD_TOUCHSCREEN_WAKE_GPIO, 0x3 })
 | 
							Name (_PRW, Package() { BOARD_TOUCHSCREEN_WAKE_GPIO, 0x3 })
 | 
				
			||||||
 | 
					#endif
 | 
				
			||||||
		/* Allow device to power off in S0 */
 | 
							/* Allow device to power off in S0 */
 | 
				
			||||||
		Name (_S0W, 4)
 | 
							Name (_S0W, 4)
 | 
				
			||||||
	}
 | 
						}
 | 
				
			||||||
 
 | 
				
			|||||||
@@ -76,9 +76,9 @@ Scope (\_SB.PCI0.I2C1)
 | 
				
			|||||||
				Return (0x0)
 | 
									Return (0x0)
 | 
				
			||||||
			}
 | 
								}
 | 
				
			||||||
		}
 | 
							}
 | 
				
			||||||
 | 
					#if CONFIG(CHROMEOS)
 | 
				
			||||||
		Name (_PRW, Package() { BOARD_TOUCHSCREEN_WAKE_GPIO, 0x3 })
 | 
							Name (_PRW, Package() { BOARD_TOUCHSCREEN_WAKE_GPIO, 0x3 })
 | 
				
			||||||
 | 
					#endif
 | 
				
			||||||
		/* Allow device to power off in S0 */
 | 
							/* Allow device to power off in S0 */
 | 
				
			||||||
		Name (_S0W, 4)
 | 
							Name (_S0W, 4)
 | 
				
			||||||
	}
 | 
						}
 | 
				
			||||||
 
 | 
				
			|||||||
@@ -8,8 +8,9 @@ Scope (\_SB.PCI0.I2C6)
 | 
				
			|||||||
		Name (_DDN, "Atmel Touchpad")
 | 
							Name (_DDN, "Atmel Touchpad")
 | 
				
			||||||
		Name (_UID, 2)
 | 
							Name (_UID, 2)
 | 
				
			||||||
		Name (ISTP, 1) /* Touchpad */
 | 
							Name (ISTP, 1) /* Touchpad */
 | 
				
			||||||
 | 
					#if CONFIG(CHROMEOS)
 | 
				
			||||||
		Name (_PRW, Package() { BOARD_TRACKPAD_WAKE_GPIO, 0x3 })
 | 
							Name (_PRW, Package() { BOARD_TRACKPAD_WAKE_GPIO, 0x3 })
 | 
				
			||||||
 | 
					#endif
 | 
				
			||||||
		Name (_CRS, ResourceTemplate()
 | 
							Name (_CRS, ResourceTemplate()
 | 
				
			||||||
		{
 | 
							{
 | 
				
			||||||
			I2cSerialBus (
 | 
								I2cSerialBus (
 | 
				
			||||||
 
 | 
				
			|||||||
@@ -30,9 +30,9 @@ Scope (\_SB.PCI0.I2C6)
 | 
				
			|||||||
				Return (0x0)
 | 
									Return (0x0)
 | 
				
			||||||
			}
 | 
								}
 | 
				
			||||||
		}
 | 
							}
 | 
				
			||||||
 | 
					#if CONFIG(CHROMEOS)
 | 
				
			||||||
		Name (_PRW, Package() { BOARD_TRACKPAD_WAKE_GPIO, 0x3 })
 | 
							Name (_PRW, Package() { BOARD_TRACKPAD_WAKE_GPIO, 0x3 })
 | 
				
			||||||
 | 
					#endif
 | 
				
			||||||
		/* Allow device to power off in S0 */
 | 
							/* Allow device to power off in S0 */
 | 
				
			||||||
		Name (_S0W, 4)
 | 
							Name (_S0W, 4)
 | 
				
			||||||
	}
 | 
						}
 | 
				
			||||||
 
 | 
				
			|||||||
		Reference in New Issue
	
	Block a user