soc/intel/apollolake: Add SGX support

- Call into commmon SGX code to configure core PRMRR and follow
  other SGX init seqeuence.
- Enable SOC_INTEL_COMMON_BLOCK_SGX for both GLK
- Enable SOC_INTEL_COMMON_BLOCK_CPU_MPINIT for GLK, as MP init needs
  to be completed before calling into fsp-s for SGX.

Change-Id: I9331cf5b2cbc86431e2749b84a55f77f7f3c5960
Signed-off-by: Pratik Prajapati <pratikkumar.v.prajapati@intel.com>
Reviewed-on: https://review.coreboot.org/21276
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Subrata Banik <subrata.banik@intel.com>
This commit is contained in:
Pratik Prajapati 2017-08-29 14:27:07 -07:00 committed by Subrata Banik
parent 4bc6edf909
commit dc194e2bc4
2 changed files with 48 additions and 2 deletions

View File

@ -7,6 +7,8 @@ config SOC_INTEL_GLK
bool bool
default n default n
select SOC_INTEL_APOLLOLAKE select SOC_INTEL_APOLLOLAKE
select SOC_INTEL_COMMON_BLOCK_CPU_MPINIT
select SOC_INTEL_COMMON_BLOCK_SGX
help help
Intel GLK support Intel GLK support

View File

@ -1,7 +1,7 @@
/* /*
* This file is part of the coreboot project. * This file is part of the coreboot project.
* *
* Copyright (C) 2015-2016 Intel Corp. * Copyright (C) 2015-2017 Intel Corp.
* (Written by Andrey Petrov <andrey.petrov@intel.com> for Intel Corp.) * (Written by Andrey Petrov <andrey.petrov@intel.com> for Intel Corp.)
* (Written by Alexandru Gagniuc <alexandrux.gagniuc@intel.com> for Intel Corp.) * (Written by Alexandru Gagniuc <alexandrux.gagniuc@intel.com> for Intel Corp.)
* *
@ -16,7 +16,9 @@
* GNU General Public License for more details. * GNU General Public License for more details.
*/ */
#include <assert.h>
#include <console/console.h> #include <console/console.h>
#include "chip.h"
#include <cpu/cpu.h> #include <cpu/cpu.h>
#include <cpu/x86/cache.h> #include <cpu/x86/cache.h>
#include <cpu/x86/mp.h> #include <cpu/x86/mp.h>
@ -32,11 +34,13 @@
#include <intelblocks/fast_spi.h> #include <intelblocks/fast_spi.h>
#include <intelblocks/mp_init.h> #include <intelblocks/mp_init.h>
#include <intelblocks/msr.h> #include <intelblocks/msr.h>
#include <intelblocks/sgx.h>
#include <intelblocks/smm.h> #include <intelblocks/smm.h>
#include <reg_script.h> #include <reg_script.h>
#include <romstage_handoff.h> #include <romstage_handoff.h>
#include <soc/cpu.h> #include <soc/cpu.h>
#include <soc/iomap.h> #include <soc/iomap.h>
#include <soc/pci_devs.h>
#include <soc/pm.h> #include <soc/pm.h>
static const struct reg_script core_msr_script[] = { static const struct reg_script core_msr_script[] = {
@ -62,6 +66,12 @@ static const struct reg_script core_msr_script[] = {
void soc_core_init(device_t cpu) void soc_core_init(device_t cpu)
{ {
/* Clear out pending MCEs */
/* TODO(adurbin): This should only be done on a cold boot. Also, some
* of these banks are core vs package scope. For now every CPU clears
* every bank. */
mca_configure();
/* Set core MSRs */ /* Set core MSRs */
reg_script_run(core_msr_script); reg_script_run(core_msr_script);
/* /*
@ -70,6 +80,10 @@ void soc_core_init(device_t cpu)
* implemented in microcode. * implemented in microcode.
*/ */
enable_pm_timer_emulation(); enable_pm_timer_emulation();
/* Configure Core PRMRR for SGX. */
if (IS_ENABLED(CONFIG_SOC_INTEL_COMMON_BLOCK_SGX))
prmrr_core_configure();
} }
#if !IS_ENABLED(CONFIG_SOC_INTEL_COMMON_BLOCK_CPU_MPINIT) #if !IS_ENABLED(CONFIG_SOC_INTEL_COMMON_BLOCK_CPU_MPINIT)
@ -213,6 +227,15 @@ static void relocation_handler(int cpu, uintptr_t curr_smbase,
* the microcode on all cores before releasing them from reset. That means that * the microcode on all cores before releasing them from reset. That means that
* the BSP and all APs will come up with the same microcode revision. * the BSP and all APs will come up with the same microcode revision.
*/ */
static void post_mp_init(void)
{
smm_southbridge_enable();
if (IS_ENABLED(CONFIG_SOC_INTEL_COMMON_BLOCK_SGX))
mp_run_on_all_cpus(sgx_configure, 2000);
}
static const struct mp_ops mp_ops = { static const struct mp_ops mp_ops = {
.pre_mp_init = pre_mp_init, .pre_mp_init = pre_mp_init,
.get_cpu_count = get_cpu_count, .get_cpu_count = get_cpu_count,
@ -220,7 +243,7 @@ static const struct mp_ops mp_ops = {
.get_microcode_info = get_microcode_info, .get_microcode_info = get_microcode_info,
.pre_mp_smm_init = smm_southbridge_clear_state, .pre_mp_smm_init = smm_southbridge_clear_state,
.relocation_handler = relocation_handler, .relocation_handler = relocation_handler,
.post_mp_init = smm_southbridge_enable, .post_mp_init = post_mp_init,
}; };
void soc_init_cpus(struct bus *cpu_bus) void soc_init_cpus(struct bus *cpu_bus)
@ -241,3 +264,24 @@ void apollolake_init_cpus(struct device *dev)
IS_ENABLED(CONFIG_BOOT_DEVICE_SPI_FLASH)) IS_ENABLED(CONFIG_BOOT_DEVICE_SPI_FLASH))
fast_spi_cache_bios_region(); fast_spi_cache_bios_region();
} }
void cpu_lock_sgx_memory(void)
{
/* Do nothing because MCHECK while loading microcode and enabling
* IA untrusted mode takes care of necessary locking */
}
int soc_fill_sgx_param(struct sgx_param *sgx_param)
{
device_t dev = SA_DEV_ROOT;
assert(dev != NULL);
config_t *conf = dev->chip_info;
if (!conf) {
printk(BIOS_ERR, "Failed to get chip_info for SGX param\n");
return -1;
}
sgx_param->enable = conf->sgx_enable;
return 0;
}