sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/apollolake: Fix bitshift issue in bootblock

Browse Source 
Fix issue where zero-sized BIOS region could cause bitshift
for '-1' which is an unspecified behavior.

Change-Id: Icb62bf413a1a0d293657503ef21fe97b5f9a5484
Signed-off-by: Andrey Petrov <andrey.petrov@intel.com>
Reviewed-on: https://review.coreboot.org/15727
Tested-by: build bot (Jenkins)
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
This commit is contained in:
Andrey Petrov 2016-07-18 07:59:03 -07:00 committed by Martin Roth
parent b921725b52
commit dc97b1ce2f
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/soc/intel/apollolake/bootblock/bootblock.c
View File

@ -100,6 +100,9 @@ static void cache_bios_region(void)
/* Only the IFD BIOS region is memory mapped (at top of 4G) */ /* Only the IFD BIOS region is memory mapped (at top of 4G) */
rom_size = get_bios_size(); rom_size = get_bios_size();
if (!rom_size)
return;
/* Round to power of two */ /* Round to power of two */
alignment = 1 << (log2_ceil(rom_size)); alignment = 1 << (log2_ceil(rom_size));
rom_size = ALIGN_UP(rom_size, alignment); rom_size = ALIGN_UP(rom_size, alignment);