timestamps: COLLECT_TIMESTAMPS is mostly optional
It is a user-visible option and enabled by default for ARCH_X86, some consider it as debugging aid only. Therefore platform design should not depend on it. It must remain selected with CHROMEOS and boards are allowed to explicitly select it as well. For siemens/mc_bdx1,mc_aplX boot time will be increased due the use of get_us_since_boot() with COLLECT_TIMESTAMPS=n. When unable to determine if N seconds has elapsed from boot, this turns into a delay of N seconds. Change-Id: I6ee4195d266440143344781d39db9578cd8bdcb3 Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/36527 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Aaron Durbin <adurbin@chromium.org> Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
This commit is contained in:
@@ -38,7 +38,6 @@ config CPU_SPECIFIC_OPTIONS
|
|||||||
select SOC_AMD_COMMON_BLOCK_SPI
|
select SOC_AMD_COMMON_BLOCK_SPI
|
||||||
select TSC_SYNC_LFENCE
|
select TSC_SYNC_LFENCE
|
||||||
select UDELAY_TSC
|
select UDELAY_TSC
|
||||||
select COLLECT_TIMESTAMPS
|
|
||||||
select SOC_AMD_PI
|
select SOC_AMD_PI
|
||||||
select SOC_AMD_COMMON
|
select SOC_AMD_COMMON
|
||||||
select SOC_AMD_COMMON_BLOCK
|
select SOC_AMD_COMMON_BLOCK
|
||||||
|
@@ -54,7 +54,6 @@ config CPU_SPECIFIC_OPTIONS
|
|||||||
select HAVE_USBDEBUG_OPTIONS
|
select HAVE_USBDEBUG_OPTIONS
|
||||||
select SOC_AMD_COMMON_BLOCK_SPI
|
select SOC_AMD_COMMON_BLOCK_SPI
|
||||||
select TSC_SYNC_LFENCE
|
select TSC_SYNC_LFENCE
|
||||||
select COLLECT_TIMESTAMPS
|
|
||||||
select SOC_AMD_PI
|
select SOC_AMD_PI
|
||||||
select SOC_AMD_COMMON
|
select SOC_AMD_COMMON
|
||||||
select SOC_AMD_COMMON_BLOCK
|
select SOC_AMD_COMMON_BLOCK
|
||||||
|
@@ -40,7 +40,6 @@ config CPU_SPECIFIC_OPTIONS
|
|||||||
# Misc options
|
# Misc options
|
||||||
select C_ENVIRONMENT_BOOTBLOCK
|
select C_ENVIRONMENT_BOOTBLOCK
|
||||||
select CACHE_MRC_SETTINGS
|
select CACHE_MRC_SETTINGS
|
||||||
select COLLECT_TIMESTAMPS
|
|
||||||
select COMMON_FADT
|
select COMMON_FADT
|
||||||
select FSP_PLATFORM_MEMORY_SETTINGS_VERSIONS
|
select FSP_PLATFORM_MEMORY_SETTINGS_VERSIONS
|
||||||
select GENERIC_GPIO_LIB
|
select GENERIC_GPIO_LIB
|
||||||
|
@@ -14,7 +14,6 @@ config CPU_SPECIFIC_OPTIONS
|
|||||||
select ARCH_VERSTAGE_X86_32
|
select ARCH_VERSTAGE_X86_32
|
||||||
select BOOT_DEVICE_SUPPORTS_WRITES
|
select BOOT_DEVICE_SUPPORTS_WRITES
|
||||||
select CACHE_MRC_SETTINGS
|
select CACHE_MRC_SETTINGS
|
||||||
select COLLECT_TIMESTAMPS
|
|
||||||
select SUPPORT_CPU_UCODE_IN_CBFS
|
select SUPPORT_CPU_UCODE_IN_CBFS
|
||||||
select MICROCODE_BLOB_NOT_IN_BLOB_REPO
|
select MICROCODE_BLOB_NOT_IN_BLOB_REPO
|
||||||
select CPU_INTEL_TURBO_NOT_PACKAGE_SCOPED
|
select CPU_INTEL_TURBO_NOT_PACKAGE_SCOPED
|
||||||
|
@@ -26,7 +26,6 @@ config CPU_SPECIFIC_OPTIONS
|
|||||||
select BOOT_DEVICE_SPI_FLASH_RW_NOMMAP_EARLY if BOOT_DEVICE_SPI_FLASH
|
select BOOT_DEVICE_SPI_FLASH_RW_NOMMAP_EARLY if BOOT_DEVICE_SPI_FLASH
|
||||||
select BOOT_DEVICE_SUPPORTS_WRITES
|
select BOOT_DEVICE_SUPPORTS_WRITES
|
||||||
select CACHE_MRC_SETTINGS
|
select CACHE_MRC_SETTINGS
|
||||||
select COLLECT_TIMESTAMPS
|
|
||||||
select COMMON_FADT
|
select COMMON_FADT
|
||||||
select CPU_INTEL_COMMON
|
select CPU_INTEL_COMMON
|
||||||
select CPU_INTEL_FIRMWARE_INTERFACE_TABLE
|
select CPU_INTEL_FIRMWARE_INTERFACE_TABLE
|
||||||
|
Reference in New Issue
Block a user