drivers/spi: Re-factor spi_crop_chunk
spi_crop_chunk is a property of the SPI controller since it depends upon the maximum transfer size that is supported by the controller. Also, it is possible to implement this within spi-generic layer by obtaining following parameters from the controller: 1. max_xfer_size: Maximum transfer size supported by the controller (Size of 0 indicates invalid size, and unlimited transfer size is indicated by UINT32_MAX.) 2. deduct_cmd_len: Whether cmd_len needs to be deducted from the max_xfer_size to determine max data size that can be transferred. (This is used by the amd boards.) Change-Id: I81c199413f879c664682088e93bfa3f91c6a46e5 Signed-off-by: Furquan Shaikh <furquan@chromium.org> Reviewed-on: https://review.coreboot.org/19386 Reviewed-by: Aaron Durbin <adurbin@chromium.org> Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Tested-by: coreboot org <coreboot.org@gmail.com>
This commit is contained in:
committed by
Martin Roth
parent
f1db5fdb4d
commit
de705fa1f4
@@ -46,7 +46,7 @@ void spiconsole_tx_byte(unsigned char c) {
|
||||
};
|
||||
|
||||
/* Verify the spi buffer is big enough to send even a single byte */
|
||||
if (spi_crop_chunk(0,MAX_MSG_LENGTH) <
|
||||
if (spi_crop_chunk(&slave, 0, MAX_MSG_LENGTH) <
|
||||
sizeof(struct em100_msg_header) + 1)
|
||||
return;
|
||||
|
||||
@@ -55,7 +55,7 @@ void spiconsole_tx_byte(unsigned char c) {
|
||||
|
||||
/* Send the data on newline or when the max spi length is reached */
|
||||
if (c == '\n' || (sizeof(struct em100_msg_header) +
|
||||
msg.header.msg_length == spi_crop_chunk(0,
|
||||
msg.header.msg_length == spi_crop_chunk(&slave, 0,
|
||||
MAX_MSG_LENGTH))) {
|
||||
spi_xfer(&slave, &msg, sizeof(struct em100_msg_header) +
|
||||
msg.header.msg_length, NULL, 0);
|
||||
|
||||
Reference in New Issue
Block a user