sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd: remove special GPIO_2 override soc_gpio_hook

Browse Source 
This override was added to have the SCI mapping configured if GPIO was
used as WAKE_L pin. This however didn't set up the SCI level and trigger
information, so it likely never worked as intended.

Change-Id: I44661f05c8f517ece88714c625603579731d174b
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/43049
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
This commit is contained in:
Kyösti Mälkki
2020-07-03 00:24:28 +03:00
committed by Felix Held
parent f8e440cadf
commit de7262f82c
5 changed files with 0 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/soc/amd/picasso/gpio.c
View File

@@ -1,10 +1,7 @@
/* SPDX-License-Identifier: GPL-2.0-only */
#include <amdblocks/gpio_banks.h>
#include <amdblocks/acpimmio.h>
#include <amdblocks/smi.h>
#include <soc/gpio.h>
#include <soc/smi.h>
#include <types.h>
static const struct soc_amd_event gpio_event_table[] = {
@@ -39,10 +36,3 @@ void soc_get_gpio_event_table(const struct soc_amd_event **table, size_t *items)
*table = gpio_event_table;
*items = ARRAY_SIZE(gpio_event_table);
}
void soc_gpio_hook(uint8_t gpio, uint8_t mux)
{
/* Always program Gevent when WAKE_L_AGPIO2 is configured as WAKE_L */
if ((gpio == 2) && !(mux & AMD_GPIO_MUX_MASK))
soc_route_sci(GPIO_2_EVENT);
}