Static CBMEM / CAR: Flag boards with BROKEN_CAR_MIGRATE

Use of CAR_GLOBAL is not safe after CAR is torn down, unless the
board properly implements EARLY_CBMEM_INIT.

Flag vulnerable boards that only do cbmem_recovery() in romstage on S3
resume and implementation with Intel FSP that invalidates cache before
we have a chance to copy the contents.

Change-Id: Iecd10dee9b73ab3f1f66826950fa0945675ff39f
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: http://review.coreboot.org/5419
Tested-by: build bot (Jenkins)
Reviewed-by: Aaron Durbin <adurbin@google.com>
This commit is contained in:
Kyösti Mälkki
2014-03-28 23:46:45 +02:00
parent 0ec3f493a3
commit deb2cb27e9
9 changed files with 19 additions and 4 deletions

View File

@@ -170,6 +170,15 @@ config EARLY_CBMEM_INIT
some, for instance, execution timestamps. It needs support in
romstage.c and should be enabled by the board's Kconfig.
config BROKEN_CAR_MIGRATE
bool
default y if !EARLY_CBMEM_INIT && HAVE_ACPI_RESUME
default n
help
Many boards use CAR_GLOBAL but have no EARLY_CBMEM_INIT and
manage CAR migration on S3 resume path only. Couple boards use
CAR_GLOBAL and never do CAR migration.
config DYNAMIC_CBMEM
bool "The CBMEM space is dynamically grown."
default n