From dedd77f6dc4b9a7bef24ddd535d3ef4e2bf9dae9 Mon Sep 17 00:00:00 2001 From: Karthikeyan Ramasubramanian Date: Mon, 29 Mar 2021 16:30:56 -0600 Subject: [PATCH] soc/amd/cezanne: Comment the AOAC register access Causing the AOAC register access as part of system suspend (S3) causes the suspend procedure to be stuck. Comment it for now to unblock entering S3 and collecting the power numbers. BUG=b:181766974 TEST=Build and boot to OS in Majolica. Enter S3 through "echo mem > /sys/power/state". Change-Id: Ie93bbe393b209b784b9a2257f3916b29d84b25d1 Signed-off-by: Karthikeyan Ramasubramanian Reviewed-on: https://review.coreboot.org/c/coreboot/+/51926 Reviewed-by: Raul Rangel Reviewed-by: Mathew King Tested-by: build bot (Jenkins) --- src/soc/amd/cezanne/acpi/mmio.asl | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/src/soc/amd/cezanne/acpi/mmio.asl b/src/soc/amd/cezanne/acpi/mmio.asl index 3f699dd771..0b4ba78e33 100644 --- a/src/soc/amd/cezanne/acpi/mmio.asl +++ b/src/soc/amd/cezanne/acpi/mmio.asl @@ -87,7 +87,8 @@ Device (FUR0) } } - AOAC_DEVICE(11, 0) + // TODO(b/183983959): Enable the AOAC register access later. + // AOAC_DEVICE(11, 0) } Device (FUR1) { @@ -118,7 +119,8 @@ Device (FUR1) { } } - AOAC_DEVICE(12, 0) + // TODO(b/183983959): Enable the AOAC register access later. + // AOAC_DEVICE(12, 0) } Device (I2C0) { @@ -154,7 +156,8 @@ Device (I2C0) { Return (0x0F) } - AOAC_DEVICE(5, 0) + // TODO(b/183983959): Enable the AOAC register access later. + // AOAC_DEVICE(5, 0) } Device (I2C1) { @@ -190,7 +193,8 @@ Device (I2C1) { Return (0x0F) } - AOAC_DEVICE(6, 0) + // TODO(b/183983959): Enable the AOAC register access later. + // AOAC_DEVICE(6, 0) } Device (I2C2) { @@ -226,7 +230,8 @@ Device (I2C2) { Return (0x0F) } - AOAC_DEVICE(7, 0) + // TODO(b/183983959): Enable the AOAC register access later. + // AOAC_DEVICE(7, 0) } Device (I2C3) @@ -262,7 +267,8 @@ Device (I2C3) Return (0x0F) } - AOAC_DEVICE(8, 0) + // TODO(b/183983959): Enable the AOAC register access later. + // AOAC_DEVICE(8, 0) } Device (MISC)