Drop explicit NULL initializations from device_operations
Unmentioned fields are initialized with 0 (or NULL) implicitly. Beside that, the struct has grown over the years. There are too many optional fields to list them all. Change-Id: Icb9e14c58153d7c14817bcde148e86e977666e4b Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr> Signed-off-by: Nico Huber <nico.h@gmx.de> Reviewed-on: https://review.coreboot.org/c/coreboot/+/40126 Reviewed-by: Angel Pons <th3fanbus@gmail.com> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
@@ -28,8 +28,6 @@ static void pci_domain_set_resources(struct device *dev)
|
||||
static struct device_operations pci_domain_ops = {
|
||||
.read_resources = pci_domain_read_resources,
|
||||
.set_resources = pci_domain_set_resources,
|
||||
.enable_resources = NULL,
|
||||
.init = NULL,
|
||||
.scan_bus = pci_domain_scan_bus,
|
||||
};
|
||||
|
||||
@@ -38,7 +36,6 @@ static struct device_operations cpu_bus_ops = {
|
||||
.set_resources = DEVICE_NOOP,
|
||||
.enable_resources = DEVICE_NOOP,
|
||||
.init = baytrail_init_cpus,
|
||||
.scan_bus = NULL,
|
||||
};
|
||||
|
||||
|
||||
|
@@ -59,8 +59,6 @@ static struct device_operations device_ops = {
|
||||
.set_resources = pci_dev_set_resources,
|
||||
.enable_resources = pci_dev_enable_resources,
|
||||
.init = emmc_init,
|
||||
.enable = NULL,
|
||||
.scan_bus = NULL,
|
||||
.ops_pci = &soc_pci_ops,
|
||||
};
|
||||
|
||||
|
@@ -100,8 +100,6 @@ static const struct device_operations device_ops = {
|
||||
.set_resources = pci_dev_set_resources,
|
||||
.enable_resources = pci_dev_enable_resources,
|
||||
.init = hda_init,
|
||||
.enable = NULL,
|
||||
.scan_bus = NULL,
|
||||
.ops_pci = &soc_pci_ops,
|
||||
};
|
||||
|
||||
|
@@ -173,8 +173,6 @@ static const struct device_operations device_ops = {
|
||||
.set_resources = pci_dev_set_resources,
|
||||
.enable_resources = pci_dev_enable_resources,
|
||||
.init = lpe_init,
|
||||
.enable = NULL,
|
||||
.scan_bus = NULL,
|
||||
.ops_pci = &soc_pci_ops,
|
||||
};
|
||||
|
||||
|
@@ -171,8 +171,6 @@ static struct device_operations device_ops = {
|
||||
.set_resources = pci_dev_set_resources,
|
||||
.enable_resources = pci_dev_enable_resources,
|
||||
.init = lpss_init,
|
||||
.enable = NULL,
|
||||
.scan_bus = NULL,
|
||||
.ops_pci = &soc_pci_ops,
|
||||
};
|
||||
|
||||
|
@@ -137,11 +137,6 @@ static void nc_read_resources(struct device *dev)
|
||||
static struct device_operations nc_ops = {
|
||||
.read_resources = nc_read_resources,
|
||||
.acpi_fill_ssdt = generate_cpu_entries,
|
||||
.set_resources = NULL,
|
||||
.enable_resources = NULL,
|
||||
.init = NULL,
|
||||
.enable = NULL,
|
||||
.scan_bus = NULL,
|
||||
.ops_pci = &soc_pci_ops,
|
||||
};
|
||||
|
||||
|
@@ -212,7 +212,6 @@ static struct device_operations sata_ops = {
|
||||
.enable_resources = pci_dev_enable_resources,
|
||||
.init = sata_init,
|
||||
.enable = sata_enable,
|
||||
.scan_bus = NULL,
|
||||
.ops_pci = &soc_pci_ops,
|
||||
};
|
||||
|
||||
|
@@ -50,8 +50,6 @@ static const struct device_operations device_ops = {
|
||||
.set_resources = pci_dev_set_resources,
|
||||
.enable_resources = pci_dev_enable_resources,
|
||||
.init = sd_init,
|
||||
.enable = NULL,
|
||||
.scan_bus = NULL,
|
||||
.ops_pci = &soc_pci_ops,
|
||||
};
|
||||
|
||||
|
@@ -523,7 +523,6 @@ static struct device_operations device_ops = {
|
||||
.set_resources = pci_dev_set_resources,
|
||||
.acpi_inject_dsdt = southcluster_inject_dsdt,
|
||||
.write_acpi_tables = acpi_write_hpet,
|
||||
.enable_resources = NULL,
|
||||
.init = sc_init,
|
||||
.enable = southcluster_enable_dev,
|
||||
.scan_bus = scan_static_bus,
|
||||
|
Reference in New Issue
Block a user