sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

src/drivers/pc80: Remove empty struct keyboard

Browse Source 
This is a empty struct that has propagated through the superio's & ec's
but really does nothing. Time to get rid of it before it adds yet more
cruft. However, since this touches many superio's at once we do this in
stages by first changing the function type to be a pure procedure.

Change-Id: Ibc732e676a9d4f0269114acabc92b15771d27ef2
Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Reviewed-on: http://review.coreboot.org/5617
Tested-by: build bot (Jenkins)
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-by: Rudolf Marek <r.marek@assembler.cz>
This commit is contained in:
Edward O'Callaghan
2014-04-30 05:01:52 +10:00
committed by Rudolf Marek
parent e61dd0f7a2
commit def00be41d
64 changed files with 84 additions and 163 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/superio/fintek/f71863fg/superio.c
View File

@@ -24,12 +24,11 @@
#include <superio/conf_mode.h>
#include <console/console.h>
#include <stdlib.h>
#include "chip.h"
#include <pc80/keyboard.h>
#include "f71863fg.h"
static void f71863fg_init(device_t dev)
{
struct superio_fintek_f71863fg_config *conf = dev->chip_info;
struct resource *res0;
if (!dev->enabled)
@@ -39,7 +38,7 @@ static void f71863fg_init(device_t dev)
/* TODO: Might potentially need code for HWM or FDC etc. */
case F71863FG_KBC:
res0 = find_resource(dev, PNP_IDX_IO0);
pc_keyboard_init(&conf->keyboard);
pc_keyboard_init();
break;
}
}

4
src/superio/fintek/f71869ad/superio.c
View File

@@ -31,15 +31,13 @@
static void f71869ad_init(device_t dev)
{
struct superio_fintek_f71869ad_config *conf = dev->chip_info;
if (!dev->enabled)
return;
switch(dev->path.pnp.device) {
/* TODO: Might potentially need code for HWM or FDC etc. */
case F71869AD_KBC:
pc_keyboard_init(&conf->keyboard);
pc_keyboard_init();
break;
case F71869AD_HWM:
f71869ad_multifunc_init(dev);

5
src/superio/fintek/f71872/superio.c
View File

@@ -24,12 +24,11 @@
#include <superio/conf_mode.h>
#include <console/console.h>
#include <stdlib.h>
#include "chip.h"
#include <pc80/keyboard.h>
#include "f71872.h"
static void f71872_init(device_t dev)
{
struct superio_fintek_f71872_config *conf = dev->chip_info;
if (!dev->enabled)
return;
@@ -37,7 +36,7 @@ static void f71872_init(device_t dev)
switch(dev->path.pnp.device) {
/* TODO: Might potentially need code for HWM or FDC etc. */
case F71872_KBC:
pc_keyboard_init(&conf->keyboard);
pc_keyboard_init();
break;
}
}

5
src/superio/fintek/f71889/superio.c
View File

@@ -24,12 +24,11 @@
#include <superio/conf_mode.h>
#include <console/console.h>
#include <stdlib.h>
#include "chip.h"
#include <pc80/keyboard.h>
#include "f71889.h"
static void f71889_init(device_t dev)
{
struct superio_fintek_f71889_config *conf = dev->chip_info;
if (!dev->enabled)
return;
@@ -37,7 +36,7 @@ static void f71889_init(device_t dev)
switch (dev->path.pnp.device) {
/* TODO: Might potentially need code for HWM or FDC etc. */
case F71889_KBC:
pc_keyboard_init(&conf->keyboard);
pc_keyboard_init();
break;
}
}

5
src/superio/fintek/f81865f/superio.c
View File

@@ -24,12 +24,11 @@
#include <superio/conf_mode.h>
#include <console/console.h>
#include <stdlib.h>
#include "chip.h"
#include <pc80/keyboard.h>
#include "f81865f.h"
static void f81865f_init(device_t dev)
{
struct superio_fintek_f81865f_config *conf = dev->chip_info;
if (!dev->enabled)
return;
@@ -37,7 +36,7 @@ static void f81865f_init(device_t dev)
switch (dev->path.pnp.device) {
/* TODO: Might potentially need code for HWM or FDC etc. */
case F81865F_KBC:
pc_keyboard_init(&conf->keyboard);
pc_keyboard_init();
break;
}
}