From df84fff80fed3ff1d2a04fd5701478a697ce226a Mon Sep 17 00:00:00 2001 From: Matt DeVillier Date: Tue, 20 Feb 2024 09:58:52 -0600 Subject: [PATCH] device/pnp_device: Demote unassigned resource printk to NOTICE Often times not all available resources are used on a PNP function, so those resources not being specified is intentional, not an error. Keep the printk but demote it so it doesn't pollute a normal cbmem log. TEST=build/boot purism/librem_cnl (Mini v2), verify errors in cbmem related to RTC IO/IRQ not being assigned are no longer present. Change-Id: I3d9f22a06088596e14680190aede2d69880001fa Signed-off-by: Matt DeVillier Reviewed-on: https://review.coreboot.org/c/coreboot/+/80645 Reviewed-by: Felix Singer Tested-by: build bot (Jenkins) Reviewed-by: Nico Huber --- src/device/pnp_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/device/pnp_device.c b/src/device/pnp_device.c index f799530d8e..c7c622804d 100644 --- a/src/device/pnp_device.c +++ b/src/device/pnp_device.c @@ -130,7 +130,7 @@ static void pnp_set_resource(struct device *dev, struct resource *resource) resource->index, resource_type(resource), resource->size); else - printk(BIOS_ERR, "%s %02lx %s size: 0x%010llx " + printk(BIOS_NOTICE, "%s %02lx %s size: 0x%010llx " "not assigned in devicetree\n", dev_path(dev), resource->index, resource_type(resource), resource->size); return;