sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

vc/amd/opensil/genoa_poc/memmap: use GiB define

Browse Source 
Use the GiB define to make the 4 GiB boundary used in some places in the
code a bit easier to read.

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: I81877a5d293c883d2e31bdb18ae3b22b8a44e62f
Reviewed-on: https://review.coreboot.org/c/coreboot/+/81093
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Varshit Pandya <pandyavarshit@gmail.com>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
This commit is contained in:
Felix Held 2024-03-05 19:44:57 +01:00
parent d4a1ba47b9
commit e067003327
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/vendorcode/amd/opensil/genoa_poc/memmap.c
View File

@ -115,7 +115,7 @@ void add_opensil_memmap(struct device *dev, unsigned long *idx)
reserved_ram_from_to(dev, (*idx)++, mem_usable, top_mem); reserved_ram_from_to(dev, (*idx)++, mem_usable, top_mem);
// Check if we're done // Check if we're done
if (top_of_mem <= 0x100000000) if (top_of_mem <= 4ULL * GiB)
return; return;
// Holes in upper DRAM // Holes in upper DRAM
@ -124,11 +124,11 @@ void add_opensil_memmap(struct device *dev, unsigned long *idx)
if (hole_info == NULL) if (hole_info == NULL)
return; return;
uint64_t lowest_upper_hole_base = top_of_mem; uint64_t lowest_upper_hole_base = top_of_mem;
uint64_t highest_upper_hole_end = 0x100000000; uint64_t highest_upper_hole_end = 4ULL * GiB;
for (int hole = 0; hole < n_holes; hole++) { for (int hole = 0; hole < n_holes; hole++) {
if (hole_info[hole].Type == MMIO) if (hole_info[hole].Type == MMIO)
continue; continue;
if (hole_info[hole].Base < 0x100000000) if (hole_info[hole].Base < 4ULL * GiB)
continue; continue;
lowest_upper_hole_base = MIN(lowest_upper_hole_base, hole_info[hole].Base); lowest_upper_hole_base = MIN(lowest_upper_hole_base, hole_info[hole].Base);
highest_upper_hole_end = MAX(highest_upper_hole_end, hole_info[hole].Base + hole_info[hole].Size); highest_upper_hole_end = MAX(highest_upper_hole_end, hole_info[hole].Base + hole_info[hole].Size);
@ -138,7 +138,7 @@ void add_opensil_memmap(struct device *dev, unsigned long *idx)
reserved_ram_range(dev, (*idx)++, hole_info[hole].Base, hole_info[hole].Size); reserved_ram_range(dev, (*idx)++, hole_info[hole].Base, hole_info[hole].Size);
} }
ram_from_to(dev, (*idx)++, 0x100000000, lowest_upper_hole_base); ram_from_to(dev, (*idx)++, 4ULL * GiB, lowest_upper_hole_base);
// Do we need this? // Do we need this?
if (top_of_mem > highest_upper_hole_end) if (top_of_mem > highest_upper_hole_end)