sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

acpi_pld: Make it easier to define the ACPI USB device groups

Browse Source 
The Linux kernel can use the ACPI _PLD group information to
determine peer ports.  Currently to define the group information
the devicetree must provide a complete _PLD structure.  This
change pulls the group information into a separate structure that
can be defined in devicetree.  This makes it easier to set for
USB devices in devicetree that do not need a full custom PLD.

This was tested on a sarien board with the USB devices defined
by verifying that the USB 2/3 ports are correctly identified
with their peer in sysfs.

Change-Id: Ifd4cadf0f6c901eb3832ad4e1395904f99c2f5a0
Signed-off-by: Duncan Laurie <dlaurie@google.com>
Reviewed-on: https://review.coreboot.org/c/29998
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
This commit is contained in:
Duncan Laurie
2018-12-01 17:14:35 -08:00
committed by Duncan Laurie
parent 1e64d2386a
commit e1eca1d91c
4 changed files with 33 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/drivers/usb/acpi/chip.h
View File

@ -46,7 +46,13 @@ struct drivers_usb_acpi_config {
*/
enum acpi_upc_type type;
/* Define a custom physical location for the port */
/* Group peer ports */
struct acpi_pld_group group;
/*
* Define a custom physical location for the port.
* If enabled, this takes precedence over the 'group' field.
*/
bool use_custom_pld;
struct acpi_pld custom_pld;

2
src/drivers/usb/acpi/usb_acpi.c
View File

@ -57,7 +57,7 @@ static void usb_acpi_fill_ssdt_generator(struct device *dev)
} else {
/* Fill PLD strucutre based on port type */
struct acpi_pld pld;
acpi_pld_fill_usb(&pld, config->type);
acpi_pld_fill_usb(&pld, config->type, &config->group);
acpigen_write_pld(&pld);
}