boardid: Minor clean up and standardization
Merge the different coreboot table strapping ID structures into one because they're really just all the same, and I want to add more. Make the signature of the board_id() function return a uint32_t because that's also what goes in the coreboot table. Add a printk to the generic code handling strapping IDs in ramstage so that not every individual mainboard implementation needs its own print. (In turn, remove one such print from fsp1_1 code because it's in the way of my next patch.) Change-Id: Ib9563edf07b623a586a4dc168fe357564c5e68b5 Signed-off-by: Julius Werner <jwerner@chromium.org> Reviewed-on: https://review.coreboot.org/22741 Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
@@ -20,7 +20,6 @@
|
||||
#include <arch/cbfs.h>
|
||||
#include <arch/early_variables.h>
|
||||
#include <assert.h>
|
||||
#include <boardid.h>
|
||||
#include <console/console.h>
|
||||
#include <cbmem.h>
|
||||
#include <cpu/intel/microcode.h>
|
||||
@@ -74,13 +73,6 @@ asmlinkage void *romstage_main(FSP_INFO_HEADER *fih)
|
||||
/* Get power state */
|
||||
params.power_state = fill_power_state();
|
||||
|
||||
/*
|
||||
* Read and print board version. Done after SOC romstage
|
||||
* in case PCH needs to be configured to talk to the EC.
|
||||
*/
|
||||
if (IS_ENABLED(CONFIG_BOARD_ID_AUTO))
|
||||
printk(BIOS_INFO, "MLB: board version %d\n", board_id());
|
||||
|
||||
/* Call into mainboard. */
|
||||
mainboard_romstage_entry(¶ms);
|
||||
soc_after_ram_init(¶ms);
|
||||
|
Reference in New Issue
Block a user