sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

usbdebug: Drop temporary disables of log output

Browse Source 
With this patch, output on usbdebug also includes the section of
MTRR setups for every CPU. This makes usbdebug output almost identical
with that of serial port and CBMEM console.

Tested with model_206ax. Also tested previously on model_f2x which does
not have these disable/enable calls in model_f2x_init() without detected issues.

Change-Id: Idfd0e93439907b17255633658195d698feab3895
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: http://review.coreboot.org/3423
Reviewed-by: Aaron Durbin <adurbin@google.com>
Tested-by: build bot (Jenkins)
This commit is contained in:
Kyösti Mälkki
2013-06-08 15:48:14 +03:00
committed by Nico Huber
parent f55a54257a
commit e49679d5a1
10 changed files with 0 additions and 148 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/cpu/intel/model_106cx/model_106cx_init.c
View File

@@ -128,10 +128,6 @@ static void configure_misc(void)
wrmsr(IA32_MISC_ENABLE, msr);
}
#if CONFIG_USBDEBUG
static unsigned ehci_debug_addr;
#endif
static void model_106cx_init(device_t cpu)
{
char processor_name[49];
@@ -146,21 +142,10 @@ static void model_106cx_init(device_t cpu)
fill_processor_name(processor_name);
printk(BIOS_INFO, "CPU: %s.\n", processor_name);
#if CONFIG_USBDEBUG
// Is this caution really needed?
if(!ehci_debug_addr)
ehci_debug_addr = get_ehci_debug();
set_ehci_debug(0);
#endif
/* Setup MTRRs */
x86_setup_mtrrs();
x86_mtrr_check();
#if CONFIG_USBDEBUG
set_ehci_debug(ehci_debug_addr);
#endif
/* Enable the local cpu apics */
setup_lapic();