sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nb/intel/gm45/gma: Use res2mmio() directly for GTT access

Browse Source 
This is how res2mmio() is supposed to be used and there was no other
use of the `mmio` variable left anyway.

Change-Id: Ifa4645bcc9ae971966587d9b67662b9dc8bae3d0
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/75377
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de>
This commit is contained in:
Nico Huber
2023-05-18 13:53:35 +02:00
committed by Felix Singer
parent e5888da8de
commit e55825f3c6
1 changed files with 1 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/northbridge/intel/gm45/gma.c
View File

@@ -172,7 +172,6 @@ const char *gm45_get_lvds_edid_str(void)
static void gma_func0_init(struct device *dev) static void gma_func0_init(struct device *dev)
{ {
u8 *mmio;
const struct northbridge_intel_gm45_config *const conf = dev->chip_info; const struct northbridge_intel_gm45_config *const conf = dev->chip_info;
const char *edid_str; const char *edid_str;
@@ -188,14 +187,12 @@ static void gma_func0_init(struct device *dev)
if (!edid_str) if (!edid_str)
printk(BIOS_ERR, "Failed to obtain LVDS EDID string!\n"); printk(BIOS_ERR, "Failed to obtain LVDS EDID string!\n");
mmio = res2mmio(gtt_res, 0, 0);
/* /*
* GTT base is at a 2M offset and is 2M big. If GTT is smaller than 2M * GTT base is at a 2M offset and is 2M big. If GTT is smaller than 2M
* cycles are simply not decoded which is fine. * cycles are simply not decoded which is fine.
*/ */
pci_or_config16(dev, PCI_COMMAND, PCI_COMMAND_MASTER); pci_or_config16(dev, PCI_COMMAND, PCI_COMMAND_MASTER);
memset(mmio + 2 * MiB, 0, 2 * MiB); memset(res2mmio(gtt_res, 2*MiB, 0), 0, 2*MiB);
if (CONFIG(NO_GFX_INIT)) if (CONFIG(NO_GFX_INIT))
pci_and_config16(dev, PCI_COMMAND, ~PCI_COMMAND_MASTER); pci_and_config16(dev, PCI_COMMAND, ~PCI_COMMAND_MASTER);