cpu/amd/agesa/family15tn/fixme.c
lint report errors and warnings Solve the next issues: - BRACES BUG = N/A TEST = N/A Change-Id: I27a712ec93c216fc3aa836baa53d6e2f2e68d3a3 Signed-off-by: Frans Hendriks <fhendriks@eltan.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/49969 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
This commit is contained in:
		
				
					committed by
					
						 Patrick Georgi
						Patrick Georgi
					
				
			
			
				
	
			
			
			
						parent
						
							aafa1621e1
						
					
				
				
					commit
					e5aafb6fbe
				
			| @@ -15,7 +15,7 @@ void amd_initcpuio(void) | ||||
| 	AMD_CONFIG_PARAMS             StdHeader; | ||||
|  | ||||
| 	/* Enable legacy video routing: D18F1xF4 VGA Enable */ | ||||
| 	PciAddress.AddressValue = MAKE_SBDFO (0, 0, 0x18, 1, 0xF4); | ||||
| 	PciAddress.AddressValue = MAKE_SBDFO(0, 0, 0x18, 1, 0xF4); | ||||
| 	PciData = 1; | ||||
| 	LibAmdPciWrite(AccessWidth32, PciAddress, &PciData, &StdHeader); | ||||
|  | ||||
| @@ -23,29 +23,29 @@ void amd_initcpuio(void) | ||||
| 	 * devices (TPM, HPET, BIOS RAM, Watchdog Timer, I/O APIC and ACPI) are | ||||
| 	 * set to non-posted regions. | ||||
| 	 */ | ||||
| 	PciAddress.AddressValue = MAKE_SBDFO (0, 0, 0x18, 1, 0x84); | ||||
| 	PciAddress.AddressValue = MAKE_SBDFO(0, 0, 0x18, 1, 0x84); | ||||
| 	PciData = 0x00FEDF00; /* last address before processor local APIC at FEE00000 */ | ||||
| 	PciData |= 1 << 7;    /* set NP (non-posted) bit */ | ||||
| 	LibAmdPciWrite(AccessWidth32, PciAddress, &PciData, &StdHeader); | ||||
| 	PciAddress.AddressValue = MAKE_SBDFO (0, 0, 0x18, 1, 0x80); | ||||
| 	PciAddress.AddressValue = MAKE_SBDFO(0, 0, 0x18, 1, 0x80); | ||||
| 	PciData = (0xFED00000 >> 8) | 3; /* lowest NP address is HPET at FED00000 */ | ||||
| 	LibAmdPciWrite(AccessWidth32, PciAddress, &PciData, &StdHeader); | ||||
|  | ||||
| 	/* Map the remaining PCI hole as posted MMIO */ | ||||
| 	PciAddress.AddressValue = MAKE_SBDFO (0, 0, 0x18, 1, 0x8C); | ||||
| 	PciAddress.AddressValue = MAKE_SBDFO(0, 0, 0x18, 1, 0x8C); | ||||
| 	PciData = 0x00FECF00; /* last address before non-posted range */ | ||||
| 	LibAmdPciWrite(AccessWidth32, PciAddress, &PciData, &StdHeader); | ||||
| 	LibAmdMsrRead(TOP_MEM, &MsrReg, &StdHeader); | ||||
| 	MsrReg = (MsrReg >> 8) | 3; | ||||
| 	PciAddress.AddressValue = MAKE_SBDFO (0, 0, 0x18, 1, 0x88); | ||||
| 	PciAddress.AddressValue = MAKE_SBDFO(0, 0, 0x18, 1, 0x88); | ||||
| 	PciData = (UINT32)MsrReg; | ||||
| 	LibAmdPciWrite(AccessWidth32, PciAddress, &PciData, &StdHeader); | ||||
|  | ||||
| 	/* Send all IO (0000-FFFF) to southbridge. */ | ||||
| 	PciAddress.AddressValue = MAKE_SBDFO (0, 0, 0x18, 1, 0xC4); | ||||
| 	PciAddress.AddressValue = MAKE_SBDFO(0, 0, 0x18, 1, 0xC4); | ||||
| 	PciData = 0x0000F000; | ||||
| 	LibAmdPciWrite(AccessWidth32, PciAddress, &PciData, &StdHeader); | ||||
| 	PciAddress.AddressValue = MAKE_SBDFO (0, 0, 0x18, 1, 0xC0); | ||||
| 	PciAddress.AddressValue = MAKE_SBDFO(0, 0, 0x18, 1, 0xC0); | ||||
| 	PciData = 0x00000003; | ||||
| 	LibAmdPciWrite(AccessWidth32, PciAddress, &PciData, &StdHeader); | ||||
| } | ||||
|   | ||||
		Reference in New Issue
	
	Block a user