sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

superio/intel/i3100: Use link-time symbol over .c includes

Browse Source 
Change-Id: I83db9b189e672b0e1f25bc42b73639c375bea3e5
Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Reviewed-on: http://review.coreboot.org/8054
Tested-by: build bot (Jenkins)
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
This commit is contained in:
Edward O'Callaghan
2015-01-04 04:25:38 +11:00
parent 24fb03e767
commit e64f5b1bcd
6 changed files with 15 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/mainboard/intel/eagleheights/romstage.c
View File

@@ -33,7 +33,7 @@
#include "southbridge/intel/i3100/early_smbus.c" #include "southbridge/intel/i3100/early_smbus.c"
#include "southbridge/intel/i3100/early_lpc.c" #include "southbridge/intel/i3100/early_lpc.c"
#include "southbridge/intel/i3100/reset.c" #include "southbridge/intel/i3100/reset.c"
#include "superio/intel/i3100/early_serial.c" #include <superio/intel/i3100/i3100.h>
#include <superio/smsc/smscsuperio/smscsuperio.h> #include <superio/smsc/smscsuperio/smscsuperio.h>
#include "northbridge/intel/i3100/i3100.h" #include "northbridge/intel/i3100/i3100.h"
#include "southbridge/intel/i3100/i3100.h" #include "southbridge/intel/i3100/i3100.h"

1
src/mainboard/intel/mtarvon/romstage.c
View File

@@ -30,7 +30,6 @@
#include "southbridge/intel/i3100/early_lpc.c" #include "southbridge/intel/i3100/early_lpc.c"
#include "northbridge/intel/i3100/raminit.h" #include "northbridge/intel/i3100/raminit.h"
#include <superio/intel/i3100/i3100.h> #include <superio/intel/i3100/i3100.h>
#include "superio/intel/i3100/early_serial.c"
#include "northbridge/intel/i3100/memory_initialized.c" #include "northbridge/intel/i3100/memory_initialized.c"
#include "cpu/x86/bist.h" #include "cpu/x86/bist.h"
#include <spd.h> #include <spd.h>

1
src/mainboard/intel/truxton/romstage.c
View File

@@ -32,7 +32,6 @@
#include "northbridge/intel/i3100/raminit_ep80579.h" #include "northbridge/intel/i3100/raminit_ep80579.h"
#include <superio/intel/i3100/i3100.h> #include <superio/intel/i3100/i3100.h>
#include "cpu/x86/mtrr/earlymtrr.c" #include "cpu/x86/mtrr/earlymtrr.c"
#include "superio/intel/i3100/early_serial.c"
#include "lib/debug.c" // XXX #include "lib/debug.c" // XXX
#include "cpu/x86/bist.h" #include "cpu/x86/bist.h"
#include <spd.h> #include <spd.h>

1
src/superio/intel/i3100/Makefile.inc
View File

@@ -18,4 +18,5 @@
## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
## ##
romstage-$(CONFIG_SUPERIO_INTEL_I3100) += early_serial.c
ramstage-$(CONFIG_SUPERIO_INTEL_I3100) += superio.c ramstage-$(CONFIG_SUPERIO_INTEL_I3100) += superio.c

6
src/superio/intel/i3100/early_serial.c
View File

@@ -19,6 +19,8 @@
*/ */
#include <arch/io.h> #include <arch/io.h>
#include <device/pnp.h>
#include <stdint.h>
#include "i3100.h" #include "i3100.h"
static void pnp_enter_ext_func_mode(pnp_devfn_t dev) static void pnp_enter_ext_func_mode(pnp_devfn_t dev)
@@ -38,14 +40,14 @@ static void pnp_exit_ext_func_mode(pnp_devfn_t dev)
} }
/* Enable device interrupts, set UART_CLK predivide. */ /* Enable device interrupts, set UART_CLK predivide. */
static void i3100_configure_uart_clk(pnp_devfn_t dev, u8 predivide) void i3100_configure_uart_clk(pnp_devfn_t dev, u8 predivide)
{ {
pnp_enter_ext_func_mode(dev); pnp_enter_ext_func_mode(dev);
pnp_write_config(dev, I3100_SIW_CONFIGURATION, (predivide << 2) | 1); pnp_write_config(dev, I3100_SIW_CONFIGURATION, (predivide << 2) | 1);
pnp_exit_ext_func_mode(dev); pnp_exit_ext_func_mode(dev);
} }
static void i3100_enable_serial(pnp_devfn_t dev, u16 iobase) void i3100_enable_serial(pnp_devfn_t dev, u16 iobase)
{ {
pnp_enter_ext_func_mode(dev); pnp_enter_ext_func_mode(dev);
pnp_set_logical_device(dev); pnp_set_logical_device(dev);

12
src/superio/intel/i3100/i3100.h
View File

@@ -18,8 +18,8 @@
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
*/ */
#ifndef SUPERIO_INTEL_I3100_I3100_H #ifndef SUPERIO_INTEL_I3100_H
#define SUPERIO_INTEL_I3100_I3100_H #define SUPERIO_INTEL_I3100_H
/* /*
* Datasheet: * Datasheet:
@@ -61,4 +61,10 @@
#define I3100_UART_CLK_PREDIVIDE_8 0x01 #define I3100_UART_CLK_PREDIVIDE_8 0x01
#define I3100_UART_CLK_PREDIVIDE_26 0x02 #define I3100_UART_CLK_PREDIVIDE_26 0x02
#endif #include <arch/io.h>
#include <stdint.h>
void i3100_configure_uart_clk(pnp_devfn_t dev, u8 predivide);
void i3100_enable_serial(pnp_devfn_t dev, u16 iobase);
#endif /* SUPERIO_INTEL_I3100_H */