sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

src: Replace remaining {get,set}_option() instances

Browse Source 
With this change, the type-unsafe {get,set}_option() API functions are
no longer used directly. The old API gets dropped in a follow-up.

Change-Id: Id3f3e172c850d50a7d2f348b1c3736969c73837d
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/52512
Reviewed-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Reviewed-by: Patrick Rudolph <siro@das-labor.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Angel Pons
2021-04-19 15:20:28 +02:00
parent 3aa757d705
commit e76f15f4fd
5 changed files with 8 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/drivers/lenovo/hybrid_graphics/hybrid_graphics.c
View File

@@ -14,7 +14,7 @@
static void lenovo_hybrid_graphics_enable(struct device *dev)
{
const struct drivers_lenovo_hybrid_graphics_config *config;
enum hybrid_graphics_req mode = HYBRID_GRAPHICS_DEFAULT_GPU;
enum hybrid_graphics_req mode;
/* Don't confuse anyone else and disable the fake device */
dev->enabled = 0;
@@ -25,7 +25,7 @@ static void lenovo_hybrid_graphics_enable(struct device *dev)
return;
}
get_option(&mode, "hybrid_graphics_mode");
mode = get_int_option("hybrid_graphics_mode", HYBRID_GRAPHICS_DEFAULT_GPU);
if (mode == HYBRID_GRAPHICS_DISCRETE) {
printk(BIOS_DEBUG, "Hybrid graphics:"

4
src/drivers/lenovo/hybrid_graphics/romstage.c
View File

@@ -18,7 +18,7 @@ void early_hybrid_graphics(bool *enable_igd, bool *enable_peg)
{
const struct drivers_lenovo_hybrid_graphics_config *config;
const struct device *dev;
enum hybrid_graphics_req mode = HYBRID_GRAPHICS_DEFAULT_GPU;
enum hybrid_graphics_req mode;
/* TODO: Use generic device instead of dummy PNP device */
dev = dev_find_slot_pnp(HYBRID_GRAPHICS_PORT, HYBRID_GRAPHICS_DEVICE);
@@ -39,7 +39,7 @@ void early_hybrid_graphics(bool *enable_igd, bool *enable_peg)
return;
}
get_option(&mode, "hybrid_graphics_mode");
mode = get_int_option("hybrid_graphics_mode", HYBRID_GRAPHICS_DEFAULT_GPU);
if (mode == HYBRID_GRAPHICS_DISCRETE) {
printk(BIOS_DEBUG, "Hybrid graphics:"