sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

src/arch/x86/acpi: Constify struct device instances

Browse Source 
Constify the struct device arguments in below APIs:
> acpi_device_name
> acpi_device_path_fill
> acpi_device_path
> acpi_write_dbg2_pci_uart
> acpi_device_scope
> acpi_device_path_join

The APIs do not seem to modify the argument and are using
device argument as reference to device only.

Change-Id: Ic2ce045f17efa288eb41503795723d0ad5ec78bd
Signed-off-by: Aamir Bohra <aamir.bohra@intel.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/34625
Reviewed-by: Subrata Banik <subrata.banik@intel.com>
Reviewed-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Aamir Bohra
2019-07-30 10:11:41 +05:30
committed by Martin Roth
parent b7ec252d37
commit e825d3f4d6
4 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/arch/x86/acpi_device.c
View File

@@ -53,9 +53,9 @@ static void acpi_device_fill_len(void *ptr)
}
/* Locate and return the ACPI name for this device */
const char *acpi_device_name(struct device *dev)
const char *acpi_device_name(const struct device *dev)
{
struct device *pdev = dev;
const struct device *pdev = dev;
const char *name = NULL;
if (!dev)
@@ -82,7 +82,7 @@ const char *acpi_device_name(struct device *dev)
}
/* Recursive function to find the root device and print a path from there */
static ssize_t acpi_device_path_fill(struct device *dev, char *buf,
static ssize_t acpi_device_path_fill(const struct device *dev, char *buf,
size_t buf_len, size_t cur)
{
const char *name = acpi_device_name(dev);
@@ -117,7 +117,7 @@ static ssize_t acpi_device_path_fill(struct device *dev, char *buf,
* Warning: just as with dev_path() this uses a static buffer
* so should not be called mulitple times in one statement
*/
const char *acpi_device_path(struct device *dev)
const char *acpi_device_path(const struct device *dev)
{
static char buf[DEVICE_PATH_MAX] = {};
@@ -131,7 +131,7 @@ const char *acpi_device_path(struct device *dev)
}
/* Return the path of the parent device as the ACPI Scope for this device */
const char *acpi_device_scope(struct device *dev)
const char *acpi_device_scope(const struct device *dev)
{
static char buf[DEVICE_PATH_MAX] = {};
@@ -145,7 +145,7 @@ const char *acpi_device_scope(struct device *dev)
}
/* Concatentate the device path and provided name suffix */
const char *acpi_device_path_join(struct device *dev, const char *name)
const char *acpi_device_path_join(const struct device *dev, const char *name)
{
static char buf[DEVICE_PATH_MAX] = {};
ssize_t len;