treewide: Remove "ERROR: "/"WARN: " prefixes from log messages
Now that the console system itself will clearly differentiate loglevels,
it is no longer necessary to explicitly add "ERROR: " in front of every
BIOS_ERR message to help it stand out more (and allow automated tooling
to grep for it). Removing all these extra .rodata characters should save
us a nice little amount of binary size.
This patch was created by running
find src/ -type f -exec perl -0777 -pi -e 's/printk\(\s*BIOS_ERR,\s*"ERROR: /printk\(BIOS_ERR, "/gi' '{}' ';'
and doing some cursory review/cleanup on the result. Then doing the same
thing for BIOS_WARN with
's/printk\(\s*BIOS_WARNING,\s*"WARN(ING)?: /printk\(BIOS_WARNING, "/gi'
Signed-off-by: Julius Werner <jwerner@chromium.org>
Change-Id: I3d0573acb23d2df53db6813cb1a5fc31b5357db8
Reviewed-on: https://review.coreboot.org/c/coreboot/+/61309
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
Reviewed-by: Lance Zhao
Reviewed-by: Jason Glenesk <jason.glenesk@gmail.com>
This commit is contained in:
@@ -52,7 +52,7 @@ static bool decompress_kernel_header(const struct fit_image_node *node)
|
||||
scratch.raw, sizeof(scratch.raw));
|
||||
break;
|
||||
default:
|
||||
printk(BIOS_ERR, "ERROR: Unsupported compression algorithm!\n");
|
||||
printk(BIOS_ERR, "Unsupported compression algorithm!\n");
|
||||
return false;
|
||||
}
|
||||
|
||||
@@ -61,8 +61,7 @@ static bool decompress_kernel_header(const struct fit_image_node *node)
|
||||
die("ERROR: Partial decompression ran over scratchbuf!\n");
|
||||
|
||||
if (scratch.header.magic != KERNEL_HEADER_MAGIC) {
|
||||
printk(BIOS_ERR,
|
||||
"ERROR: Invalid kernel magic: %#.8x\n != %#.8x\n",
|
||||
printk(BIOS_ERR, "Invalid kernel magic: %#.8x\n != %#.8x\n",
|
||||
scratch.header.magic, KERNEL_HEADER_MAGIC);
|
||||
return false;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user