treewide: Remove "ERROR: "/"WARN: " prefixes from log messages
Now that the console system itself will clearly differentiate loglevels, it is no longer necessary to explicitly add "ERROR: " in front of every BIOS_ERR message to help it stand out more (and allow automated tooling to grep for it). Removing all these extra .rodata characters should save us a nice little amount of binary size. This patch was created by running find src/ -type f -exec perl -0777 -pi -e 's/printk\(\s*BIOS_ERR,\s*"ERROR: /printk\(BIOS_ERR, "/gi' '{}' ';' and doing some cursory review/cleanup on the result. Then doing the same thing for BIOS_WARN with 's/printk\(\s*BIOS_WARNING,\s*"WARN(ING)?: /printk\(BIOS_WARNING, "/gi' Signed-off-by: Julius Werner <jwerner@chromium.org> Change-Id: I3d0573acb23d2df53db6813cb1a5fc31b5357db8 Reviewed-on: https://review.coreboot.org/c/coreboot/+/61309 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr> Reviewed-by: Lance Zhao Reviewed-by: Jason Glenesk <jason.glenesk@gmail.com>
This commit is contained in:
@@ -74,7 +74,7 @@ __weak int tis_plat_irq_status(void)
|
||||
static int warning_displayed;
|
||||
|
||||
if (!warning_displayed) {
|
||||
printk(BIOS_WARNING, "WARNING: %s() not implemented, wasting 10ms to wait on"
|
||||
printk(BIOS_WARNING, "%s() not implemented, wasting 10ms to wait on"
|
||||
" Cr50!\n", __func__);
|
||||
warning_displayed = 1;
|
||||
}
|
||||
@@ -492,7 +492,7 @@ static void cr50_set_board_cfg(void)
|
||||
/* The high bit is set, meaning that the Cr50 is already locked on a particular
|
||||
* value for the register, but not the one we wanted. */
|
||||
printk(BIOS_ERR,
|
||||
"ERROR: Current CR50_BOARD_CFG = 0x%08x, does not match desired = 0x%08x\n",
|
||||
"Current CR50_BOARD_CFG = 0x%08x, does not match desired = 0x%08x\n",
|
||||
board_cfg_value, CR50_BOARD_CFG_VALUE);
|
||||
return;
|
||||
}
|
||||
|
Reference in New Issue
Block a user