sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

treewide: Remove "ERROR: "/"WARN: " prefixes from log messages

Browse Source 
Now that the console system itself will clearly differentiate loglevels,
it is no longer necessary to explicitly add "ERROR: " in front of every
BIOS_ERR message to help it stand out more (and allow automated tooling
to grep for it). Removing all these extra .rodata characters should save
us a nice little amount of binary size.

This patch was created by running

  find src/ -type f -exec perl -0777 -pi -e 's/printk\(\s*BIOS_ERR,\s*"ERROR: /printk\(BIOS_ERR, "/gi' '{}' ';'

and doing some cursory review/cleanup on the result. Then doing the same
thing for BIOS_WARN with

  's/printk\(\s*BIOS_WARNING,\s*"WARN(ING)?: /printk\(BIOS_WARNING, "/gi'

Signed-off-by: Julius Werner <jwerner@chromium.org>
Change-Id: I3d0573acb23d2df53db6813cb1a5fc31b5357db8
Reviewed-on: https://review.coreboot.org/c/coreboot/+/61309
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
Reviewed-by: Lance Zhao
Reviewed-by: Jason Glenesk <jason.glenesk@gmail.com>
This commit is contained in:
Julius Werner
2022-01-21 17:06:20 -08:00
parent 266041f0e6
commit e9665959ed
129 changed files with 306 additions and 330 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/soc/amd/picasso/data_fabric.c
View File

@@ -66,8 +66,7 @@ void data_fabric_set_mmio_np(void)
/* Although a pair could be freed later, this condition is
* very unusual and deserves analysis. Flag an error and
* leave the topmost part unconfigured. */
printk(BIOS_ERR,
"Error: Not enough NB MMIO routing registers\n");
printk(BIOS_ERR, "Not enough NB MMIO routing registers\n");
continue;
}
data_fabric_broadcast_write32(0, NB_MMIO_BASE(reg), np_top + 1);
@@ -85,7 +84,7 @@ void data_fabric_set_mmio_np(void)
reg = data_fabric_find_unused_mmio_reg();
if (reg < 0) {
printk(BIOS_ERR, "Error: cannot configure region as NP\n");
printk(BIOS_ERR, "cannot configure region as NP\n");
return;
}

2
src/soc/amd/picasso/i2c.c
View File

@@ -30,7 +30,7 @@ static struct soc_i2c_ctrlr_info i2c_ctrlr[I2C_CTRLR_COUNT] = {
void i2c_set_bar(unsigned int bus, uintptr_t bar)
{
if (bus >= ARRAY_SIZE(i2c_ctrlr)) {
printk(BIOS_ERR, "Error: i2c index out of bounds: %u.", bus);
printk(BIOS_ERR, "i2c index out of bounds: %u.", bus);
return;
}

4
src/soc/amd/picasso/root_complex.c
View File

@@ -139,7 +139,7 @@ static void read_resources(struct device *dev)
mmconf_resource(dev, MMIO_CONF_BASE);
if (!hob) {
printk(BIOS_ERR, "Error: %s incomplete because no HOB list was found\n",
printk(BIOS_ERR, "%s incomplete because no HOB list was found\n",
__func__);
return;
}
@@ -161,7 +161,7 @@ static void read_resources(struct device *dev)
else if (res->type == EFI_RESOURCE_MEMORY_RESERVED)
reserved_ram_resource(dev, idx++, res->addr / KiB, res->length / KiB);
else
printk(BIOS_ERR, "Error: failed to set resources for type %d\n",
printk(BIOS_ERR, "failed to set resources for type %d\n",
res->type);
}

2
src/soc/amd/picasso/smihandler.c
View File

@@ -124,7 +124,7 @@ static void fch_slp_typ_handler(void)
psp_notify_sx_info(ACPI_S3);
smu_sx_entry(); /* Leave SlpTypeEn clear, SMU will set */
printk(BIOS_ERR, "Error: System did not go to sleep\n");
printk(BIOS_ERR, "System did not go to sleep\n");
hlt();
}