sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

treewide: Remove "ERROR: "/"WARN: " prefixes from log messages

Browse Source 
Now that the console system itself will clearly differentiate loglevels,
it is no longer necessary to explicitly add "ERROR: " in front of every
BIOS_ERR message to help it stand out more (and allow automated tooling
to grep for it). Removing all these extra .rodata characters should save
us a nice little amount of binary size.

This patch was created by running

  find src/ -type f -exec perl -0777 -pi -e 's/printk\(\s*BIOS_ERR,\s*"ERROR: /printk\(BIOS_ERR, "/gi' '{}' ';'

and doing some cursory review/cleanup on the result. Then doing the same
thing for BIOS_WARN with

  's/printk\(\s*BIOS_WARNING,\s*"WARN(ING)?: /printk\(BIOS_WARNING, "/gi'

Signed-off-by: Julius Werner <jwerner@chromium.org>
Change-Id: I3d0573acb23d2df53db6813cb1a5fc31b5357db8
Reviewed-on: https://review.coreboot.org/c/coreboot/+/61309
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
Reviewed-by: Lance Zhao
Reviewed-by: Jason Glenesk <jason.glenesk@gmail.com>
This commit is contained in:
Julius Werner
2022-01-21 17:06:20 -08:00
parent 266041f0e6
commit e9665959ed
129 changed files with 306 additions and 330 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/southbridge/amd/common/amd_pci_util.c
View File

@@ -89,7 +89,7 @@ void write_pci_cfg_irqs(void)
u32 i = 0;
if (pirq_data_ptr == NULL) {
printk(BIOS_WARNING, "Warning: Can't write PCI IRQ assignments because"
printk(BIOS_WARNING, "Can't write PCI IRQ assignments because"
" 'mainboard_pirq_data' structure does not exist\n");
return;
}

4
src/southbridge/intel/bd82x6x/early_me.c
View File

@@ -56,14 +56,14 @@ int intel_early_me_init(void)
udelay(ME_DELAY);
}
if (!count) {
printk(BIOS_ERR, "ERROR: ME is not ready!\n");
printk(BIOS_ERR, "ME is not ready!\n");
return -1;
}
/* Check for valid firmware */
hfs.raw = pci_read_config32(PCH_ME_DEV, PCI_ME_HFS);
if (hfs.fpt_bad) {
printk(BIOS_WARNING, "WARNING: ME has bad firmware\n");
printk(BIOS_WARNING, "ME has bad firmware\n");
return -1;
}

6
src/southbridge/intel/bd82x6x/early_me_mrc.c
View File

@@ -55,14 +55,14 @@ int intel_early_me_init(void)
udelay(ME_DELAY);
}
if (!count) {
printk(BIOS_ERR, "ERROR: ME is not ready!\n");
printk(BIOS_ERR, "ME is not ready!\n");
return -1;
}
/* Check for valid firmware */
hfs.raw = pci_read_config32(PCH_ME_DEV, PCI_ME_HFS);
if (hfs.fpt_bad) {
printk(BIOS_WARNING, "WARNING: ME has bad firmware\n");
printk(BIOS_WARNING, "ME has bad firmware\n");
return -1;
}
@@ -114,7 +114,7 @@ int intel_early_me_init_done(u8 status)
udelay(ME_DELAY);
}
if (!count) {
printk(BIOS_ERR, "ERROR: ME failed to respond\n");
printk(BIOS_ERR, "ME failed to respond\n");
return -1;
}

6
src/southbridge/intel/common/spi.c
View File

@@ -998,7 +998,7 @@ static int spi_flash_protect(const struct spi_flash *flash,
}
if (fpr == cntlr.fpr_max) {
printk(BIOS_ERR, "ERROR: No SPI FPR free!\n");
printk(BIOS_ERR, "No SPI FPR free!\n");
return -1;
}
@@ -1017,7 +1017,7 @@ static int spi_flash_protect(const struct spi_flash *flash,
protect_mask |= (ICH9_SPI_FPR_RPE | SPI_FPR_WPE);
break;
default:
printk(BIOS_ERR, "ERROR: Seeking invalid protection!\n");
printk(BIOS_ERR, "Seeking invalid protection!\n");
return -1;
}
@@ -1027,7 +1027,7 @@ static int spi_flash_protect(const struct spi_flash *flash,
/* Set the FPR register and verify it is protected */
write32(&fpr_base[fpr], reg);
if (reg != read32(&fpr_base[fpr])) {
printk(BIOS_ERR, "ERROR: Unable to set SPI FPR %d\n", fpr);
printk(BIOS_ERR, "Unable to set SPI FPR %d\n", fpr);
return -1;
}

6
src/southbridge/intel/lynxpoint/early_me.c
View File

@@ -45,14 +45,14 @@ int intel_early_me_init(void)
udelay(ME_DELAY);
}
if (!count) {
printk(BIOS_ERR, "ERROR: ME is not ready!\n");
printk(BIOS_ERR, "ME is not ready!\n");
return -1;
}
/* Check for valid firmware */
hfs.raw = pci_read_config32(PCH_ME_DEV, PCI_ME_HFS);
if (hfs.fpt_bad) {
printk(BIOS_WARNING, "WARNING: ME has bad firmware\n");
printk(BIOS_WARNING, "ME has bad firmware\n");
return -1;
}
@@ -123,7 +123,7 @@ int intel_early_me_init_done(u8 status)
udelay(ME_DELAY);
}
if (!count) {
printk(BIOS_ERR, "ERROR: ME failed to respond\n");
printk(BIOS_ERR, "ME failed to respond\n");
return -1;
}