sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

treewide: Remove "ERROR: "/"WARN: " prefixes from log messages

Browse Source 
Now that the console system itself will clearly differentiate loglevels,
it is no longer necessary to explicitly add "ERROR: " in front of every
BIOS_ERR message to help it stand out more (and allow automated tooling
to grep for it). Removing all these extra .rodata characters should save
us a nice little amount of binary size.

This patch was created by running

  find src/ -type f -exec perl -0777 -pi -e 's/printk\(\s*BIOS_ERR,\s*"ERROR: /printk\(BIOS_ERR, "/gi' '{}' ';'

and doing some cursory review/cleanup on the result. Then doing the same
thing for BIOS_WARN with

  's/printk\(\s*BIOS_WARNING,\s*"WARN(ING)?: /printk\(BIOS_WARNING, "/gi'

Signed-off-by: Julius Werner <jwerner@chromium.org>
Change-Id: I3d0573acb23d2df53db6813cb1a5fc31b5357db8
Reviewed-on: https://review.coreboot.org/c/coreboot/+/61309
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
Reviewed-by: Lance Zhao
Reviewed-by: Jason Glenesk <jason.glenesk@gmail.com>
This commit is contained in:
Julius Werner
2022-01-21 17:06:20 -08:00
parent 266041f0e6
commit e9665959ed
129 changed files with 306 additions and 330 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/superio/nuvoton/nct5104d/superio.c
View File

@@ -156,7 +156,7 @@ static void disable_gpio_io_port(struct device *dev)
if (!((gpio0 && gpio0->enabled) || (gpio1 && gpio1->enabled) ||
(gpio6 && gpio6->enabled))) {
dev->enabled = 0;
printk(BIOS_WARNING, "WARNING: GPIO IO port configured,"
printk(BIOS_WARNING, "GPIO IO port configured,"
" but no GPIO enabled. Disabling...");
}
}

4
src/superio/smsc/lpc47n217/superio.c
View File

@@ -113,7 +113,7 @@ static void lpc47n217_init(struct device *dev)
static void lpc47n217_pnp_set_resource(struct device *dev, struct resource *resource)
{
if (!(resource->flags & IORESOURCE_ASSIGNED)) {
printk(BIOS_ERR, "ERROR: %s %02lx not allocated\n",
printk(BIOS_ERR, "%s %02lx not allocated\n",
dev_path(dev), resource->index);
return;
}
@@ -131,7 +131,7 @@ static void lpc47n217_pnp_set_resource(struct device *dev, struct resource *reso
} else if (resource->flags & IORESOURCE_IRQ) {
lpc47n217_pnp_set_irq(dev, resource->base);
} else {
printk(BIOS_ERR, "ERROR: %s %02lx unknown resource type\n",
printk(BIOS_ERR, "%s %02lx unknown resource type\n",
dev_path(dev), resource->index);
return;
}

4
src/superio/smsc/lpc47n227/superio.c
View File

@@ -121,7 +121,7 @@ static void lpc47n227_init(struct device *dev)
static void lpc47n227_pnp_set_resource(struct device *dev, struct resource *resource)
{
if (!(resource->flags & IORESOURCE_ASSIGNED)) {
printk(BIOS_ERR, "ERROR: %s %02lx not allocated\n",
printk(BIOS_ERR, "%s %02lx not allocated\n",
dev_path(dev), resource->index);
return;
}
@@ -138,7 +138,7 @@ static void lpc47n227_pnp_set_resource(struct device *dev, struct resource *reso
} else if (resource->flags & IORESOURCE_IRQ) {
lpc47n227_pnp_set_irq(dev, resource->base);
} else {
printk(BIOS_ERR, "ERROR: %s %02lx unknown resource type\n",
printk(BIOS_ERR, "%s %02lx unknown resource type\n",
dev_path(dev), resource->index);
return;
}

14
src/superio/smsc/sch5545/superio.c
View File

@@ -90,7 +90,7 @@ static void sch5545_set_iobase(struct device *dev, u8 index, u16 iobase)
lpc_if = dev_find_slot_pnp(dev->path.pnp.port, SCH5545_LDN_LPC);
if (!lpc_if) {
printk(BIOS_ERR, "ERROR: %s LPC interface LDN not present."
printk(BIOS_ERR, "%s LPC interface LDN not present."
"Check the devicetree!\n", dev_path(dev));
return;
}
@@ -152,7 +152,7 @@ static void sch5545_set_irq(struct device *dev, u8 index, u8 irq)
lpc_if = dev_find_slot_pnp(dev->path.pnp.port, SCH5545_LDN_LPC);
if (!lpc_if) {
printk(BIOS_ERR, "ERROR: %s LPC interface LDN not present."
printk(BIOS_ERR, "%s LPC interface LDN not present."
"Check the devicetree!\n", dev_path(dev));
return;
}
@@ -193,7 +193,7 @@ static void sch5545_set_drq(struct device *dev, u8 index, u8 drq)
struct device *lpc_if;
if (drq == 4) {
printk(BIOS_ERR, "ERROR: %s %02x: Trying to set reserved DMA channel 4!\n",
printk(BIOS_ERR, "%s %02x: Trying to set reserved DMA channel 4!\n",
dev_path(dev), index);
printk(BIOS_ERR, "This configuration is untested. Trying to continue.\n");
}
@@ -202,7 +202,7 @@ static void sch5545_set_drq(struct device *dev, u8 index, u8 drq)
lpc_if = dev_find_slot_pnp(dev->path.pnp.port, SCH5545_LDN_LPC);
if (!lpc_if) {
printk(BIOS_ERR, "ERROR: %s LPC interface LDN not present."
printk(BIOS_ERR, "%s LPC interface LDN not present."
"Check the devicetree!\n", dev_path(dev));
return;
}
@@ -233,12 +233,12 @@ static void sch5545_set_resource(struct device *dev, struct resource *resource)
if (resource->flags & IORESOURCE_IRQ &&
(resource->index != PNP_IDX_IRQ0) &&
(resource->index != PNP_IDX_IRQ1))
printk(BIOS_WARNING, "WARNING: %s %02lx %s size: "
printk(BIOS_WARNING, "%s %02lx %s size: "
"0x%010llx not assigned\n", dev_path(dev),
resource->index, resource_type(resource),
resource->size);
else
printk(BIOS_ERR, "ERROR: %s %02lx %s size: 0x%010llx "
printk(BIOS_ERR, "%s %02lx %s size: 0x%010llx "
"not assigned\n", dev_path(dev), resource->index,
resource_type(resource), resource->size);
return;
@@ -252,7 +252,7 @@ static void sch5545_set_resource(struct device *dev, struct resource *resource)
} else if (resource->flags & IORESOURCE_IRQ) {
sch5545_set_irq(dev, resource->index, resource->base);
} else {
printk(BIOS_ERR, "ERROR: %s %02lx unknown resource type\n",
printk(BIOS_ERR, "%s %02lx unknown resource type\n",
dev_path(dev), resource->index);
return;
}