drivers/intel/gma/acpi: Reduce display switching stubs

_DCS, _DGS and _DSS are required by specification. However,
we never implemented them properly, and no OS driver com-
plained yet. So we stub them out and keep the traditional
behavior in case an OS driver checks for their existence.

The old implementations also only returned static values as
there never was any write to their GNVS variables. The TRAP()
that was called in one place is actually implemented by some
ThinkPad's SMI handler as docking event. However, as the call
precedes these SMI handlers in coreboot history, it's most
likely an accident.

Change-Id: Ib0b9fcdd58df254d3b2290900e3bc206a7abd92d
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/39726
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
This commit is contained in:
Nico Huber
2020-03-21 18:40:03 +01:00
committed by Patrick Georgi
parent cc85ce0aa0
commit e98f6af77b
15 changed files with 28 additions and 99 deletions

View File

@@ -35,11 +35,6 @@
/* Display Output Switching */
Method (_DOS, 1)
{
/* Windows 2000 and Windows XP call _DOS to enable/disable
* Display Output Switching during init and while a switch
* is already active
*/
Store (And(Arg0, 7), DSEN)
}
/*
@@ -80,33 +75,3 @@
XBCM (DerefOf (Index (BRIG, Local0)))
}
}
/* Device Current Status */
Method(XDCS, 1)
{
TRAP(1)
If (And(CSTE, ShiftLeft (1, Arg0))) {
Return (0x1f)
}
Return(0x1d)
}
/* Query Device Graphics State */
Method(XDGS, 1)
{
If (And(NSTE, ShiftLeft (1, Arg0))) {
Return(1)
}
Return(0)
}
/* Device Set State */
Method(XDSS, 1)
{
/* If Parameter Arg0 is (1 << 31) | (1 << 30), the
* display switch was completed
*/
If (LEqual(And(Arg0, 0xc0000000), 0xc0000000)) {
Store (NSTE, CSTE)
}
}