sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "soc/intel/adl: Guard TWL SoC missing UPDs for build integrity"

Browse Source 
This reverts commit 59ee65d271.

Reason for revert:
- Usb4CmMode & CnviWifiCore Upds are available starting with TWL FSP
  version v5222.01. Therefore, no special handling is required.

BUG=b:330654700
TEST=Able to build google/tivviks.

Change-Id: I3c74ec5b9924e88a26984fe8d3275ba80edb14ab
Signed-off-by: Subrata Banik <subratabanik@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/83658
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Eric Lai <ericllai@google.com>
Reviewed-by: V Sowmya <v.sowmya@intel.com>
This commit is contained in:
Subrata Banik
2024-07-26 14:30:17 +05:30
parent 85dd48fd80
commit e99d22e09f
1 changed files with 0 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/soc/intel/alderlake/fsp_params.c
View File

@@ -683,9 +683,7 @@ static void fill_fsps_tcss_params(FSP_S_CONFIG *s_cfg,
s_cfg->UsbTcPortEn |= BIT(i); s_cfg->UsbTcPortEn |= BIT(i);
} }
#if !CONFIG(SOC_INTEL_TWINLAKE)
s_cfg->Usb4CmMode = CONFIG(SOFTWARE_CONNECTION_MANAGER); s_cfg->Usb4CmMode = CONFIG(SOFTWARE_CONNECTION_MANAGER);
#endif
} }
static void fill_fsps_chipset_lockdown_params(FSP_S_CONFIG *s_cfg, static void fill_fsps_chipset_lockdown_params(FSP_S_CONFIG *s_cfg,
@@ -833,9 +831,7 @@ static void fill_fsps_cnvi_params(FSP_S_CONFIG *s_cfg,
const struct soc_intel_alderlake_config *config) const struct soc_intel_alderlake_config *config)
{ {
/* CNVi */ /* CNVi */
#if !CONFIG(SOC_INTEL_TWINLAKE)
s_cfg->CnviWifiCore = is_devfn_enabled(PCH_DEVFN_CNVI_WIFI); s_cfg->CnviWifiCore = is_devfn_enabled(PCH_DEVFN_CNVI_WIFI);
#endif
s_cfg->CnviMode = is_devfn_enabled(PCH_DEVFN_CNVI_WIFI); s_cfg->CnviMode = is_devfn_enabled(PCH_DEVFN_CNVI_WIFI);
s_cfg->CnviBtCore = config->cnvi_bt_core; s_cfg->CnviBtCore = config->cnvi_bt_core;
s_cfg->CnviBtAudioOffload = config->cnvi_bt_audio_offload; s_cfg->CnviBtAudioOffload = config->cnvi_bt_audio_offload;