sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/dedede: Add weak pull-up for EC_AP_PWR_BTN_ODL gpio

Browse Source 
According to the EDS, EC_AP_PWR_BTN_ODL has a default internal pull-up
of 20K. Retain it during the GPIO pad configuration.

BUG=b:150985246
TEST=Boot the mainboard.

Change-Id: I042ba70f78fca1a5b9eda30029df97b3f8e65656
Signed-off-by: Karthikeyan Ramasubramanian <kramasub@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/39852
Reviewed-by: Justin TerAvest <teravest@chromium.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Karthikeyan Ramasubramanian
2020-03-25 17:37:34 -06:00
committed by Furquan Shaikh
parent ea9787a6b2
commit e9eb4d5df9
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/mainboard/google/dedede/variants/baseboard/gpio.c
View File

@@ -372,7 +372,7 @@ static const struct pad_config gpio_table[] = {
/* GPD2 : EC_AP_WAKE_ODL */ /* GPD2 : EC_AP_WAKE_ODL */
PAD_CFG_NF(GPD2, NONE, DEEP, NF1), PAD_CFG_NF(GPD2, NONE, DEEP, NF1),
/* GPD3 : EC_AP_PWR_BTN_ODL */ /* GPD3 : EC_AP_PWR_BTN_ODL */
PAD_CFG_NF(GPD3, NONE, DEEP, NF1), PAD_CFG_NF(GPD3, UP_20K, DEEP, NF1),
/* GPD4 : AP_SLP_S3_L */ /* GPD4 : AP_SLP_S3_L */
PAD_CFG_NF(GPD4, NONE, DEEP, NF1), PAD_CFG_NF(GPD4, NONE, DEEP, NF1),
/* GPD5 : AP_SLP_S4_L */ /* GPD5 : AP_SLP_S4_L */