Revert "soc/intel/{tigerlake,meteorlake}: Check ITBT FW version"
This reverts commit 2e10a6d6f3.
Reason for revert: The FW version check is not supported except
for ADL platform. Reverted change broke S0ix functionality;
the original CL was added as HW W/A for ADL ONLY.
BUG=b:306214725
TEST=S0ix cycles on Rex with TBT Device attached.
Change-Id: Ib8eb11d36eac4e1c94a3349386442fa3eeeaef37
Signed-off-by: Ravi Sarawadi <ravishankar.sarawadi@intel.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/78457
Reviewed-by: Subrata Banik <subratabanik@google.com>
Reviewed-by: Kapil Porwal <kapilporwal@google.com>
Reviewed-by: Jamie Ryu <jamie.m.ryu@intel.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
			
			
This commit is contained in:
		
				
					committed by
					
						
						Subrata Banik
					
				
			
			
				
	
			
			
			
						parent
						
							f89bb82832
						
					
				
				
					commit
					ebd4c3d113
				
			@@ -452,10 +452,6 @@ Scope (\_SB.PCI0)
 | 
				
			|||||||
				/* DMA0 is not in D3Cold now. */
 | 
									/* DMA0 is not in D3Cold now. */
 | 
				
			||||||
				\_SB.PCI0.TDM0.D3CE()  /* Enable DMA RTD3 */
 | 
									\_SB.PCI0.TDM0.D3CE()  /* Enable DMA RTD3 */
 | 
				
			||||||
 | 
					
 | 
				
			||||||
				If (\_SB.PCI0.TDM0.IF30 != 1) {
 | 
					 | 
				
			||||||
					Return
 | 
					 | 
				
			||||||
				}
 | 
					 | 
				
			||||||
 | 
					 | 
				
			||||||
				Printf("Push TBT RPs to D3Cold together")
 | 
									Printf("Push TBT RPs to D3Cold together")
 | 
				
			||||||
				If (\_SB.PCI0.TRP0.VDID != 0xFFFFFFFF) {
 | 
									If (\_SB.PCI0.TRP0.VDID != 0xFFFFFFFF) {
 | 
				
			||||||
					/* Put RP0 to D3 cold. */
 | 
										/* Put RP0 to D3 cold. */
 | 
				
			||||||
@@ -511,10 +507,6 @@ Scope (\_SB.PCI0)
 | 
				
			|||||||
				/* DMA1 is not in D3Cold now */
 | 
									/* DMA1 is not in D3Cold now */
 | 
				
			||||||
				\_SB.PCI0.TDM1.D3CE()  /* Enable DMA RTD3. */
 | 
									\_SB.PCI0.TDM1.D3CE()  /* Enable DMA RTD3. */
 | 
				
			||||||
 | 
					
 | 
				
			||||||
				If (\_SB.PCI0.TDM1.IF30 != 1) {
 | 
					 | 
				
			||||||
					Return
 | 
					 | 
				
			||||||
				}
 | 
					 | 
				
			||||||
 | 
					 | 
				
			||||||
				Printf("Push TBT RPs to D3Cold together")
 | 
									Printf("Push TBT RPs to D3Cold together")
 | 
				
			||||||
				If (\_SB.PCI0.TRP2.VDID != 0xFFFFFFFF) {
 | 
									If (\_SB.PCI0.TRP2.VDID != 0xFFFFFFFF) {
 | 
				
			||||||
					/* Put RP2 to D3 cold. */
 | 
										/* Put RP2 to D3 cold. */
 | 
				
			||||||
 
 | 
				
			|||||||
@@ -11,8 +11,7 @@ Field (DPME, AnyAcc, NoLock, Preserve)
 | 
				
			|||||||
	, 6,
 | 
						, 6,
 | 
				
			||||||
	PMES, 1,        /* 15, PME_STATUS */
 | 
						PMES, 1,        /* 15, PME_STATUS */
 | 
				
			||||||
	Offset(0xC8),   /* 0xC8, TBT NVM FW Revision */
 | 
						Offset(0xC8),   /* 0xC8, TBT NVM FW Revision */
 | 
				
			||||||
	,     30,
 | 
						,     31,
 | 
				
			||||||
	IF30,  1,	/* ITBT FW Version Bit30 */
 | 
					 | 
				
			||||||
	INFR,  1,       /* TBT NVM FW Ready */
 | 
						INFR,  1,       /* TBT NVM FW Ready */
 | 
				
			||||||
	Offset(0xEC),   /* 0xEC, TBT TO PCIE Register */
 | 
						Offset(0xEC),   /* 0xEC, TBT TO PCIE Register */
 | 
				
			||||||
	TB2P, 32,       /* TBT to PCIe */
 | 
						TB2P, 32,       /* TBT to PCIe */
 | 
				
			||||||
 
 | 
				
			|||||||
@@ -567,10 +567,6 @@ Scope (\_SB.PCI0)
 | 
				
			|||||||
				/* DMA0 is not in D3Cold now. */
 | 
									/* DMA0 is not in D3Cold now. */
 | 
				
			||||||
				\_SB.PCI0.TDM0.D3CE()  /* Enable DMA RTD3 */
 | 
									\_SB.PCI0.TDM0.D3CE()  /* Enable DMA RTD3 */
 | 
				
			||||||
 | 
					
 | 
				
			||||||
				If (\_SB.PCI0.TDM0.IF30 != 1) {
 | 
					 | 
				
			||||||
					Return
 | 
					 | 
				
			||||||
				}
 | 
					 | 
				
			||||||
 | 
					 | 
				
			||||||
				Printf("Push TBT RPs to D3Cold together")
 | 
									Printf("Push TBT RPs to D3Cold together")
 | 
				
			||||||
				If (\_SB.PCI0.TRP0.VDID != 0xFFFFFFFF) {
 | 
									If (\_SB.PCI0.TRP0.VDID != 0xFFFFFFFF) {
 | 
				
			||||||
					/* Put RP0 to D3 cold. */
 | 
										/* Put RP0 to D3 cold. */
 | 
				
			||||||
@@ -626,10 +622,6 @@ Scope (\_SB.PCI0)
 | 
				
			|||||||
				/* DMA1 is not in D3Cold now */
 | 
									/* DMA1 is not in D3Cold now */
 | 
				
			||||||
				\_SB.PCI0.TDM1.D3CE()  /* Enable DMA RTD3. */
 | 
									\_SB.PCI0.TDM1.D3CE()  /* Enable DMA RTD3. */
 | 
				
			||||||
 | 
					
 | 
				
			||||||
				If (\_SB.PCI0.TDM1.IF30 != 1) {
 | 
					 | 
				
			||||||
					Return
 | 
					 | 
				
			||||||
				}
 | 
					 | 
				
			||||||
 | 
					 | 
				
			||||||
				Printf("Push TBT RPs to D3Cold together")
 | 
									Printf("Push TBT RPs to D3Cold together")
 | 
				
			||||||
				If (\_SB.PCI0.TRP2.VDID != 0xFFFFFFFF) {
 | 
									If (\_SB.PCI0.TRP2.VDID != 0xFFFFFFFF) {
 | 
				
			||||||
					/* Put RP2 to D3 cold. */
 | 
										/* Put RP2 to D3 cold. */
 | 
				
			||||||
 
 | 
				
			|||||||
@@ -11,8 +11,7 @@ Field (DPME, AnyAcc, NoLock, Preserve)
 | 
				
			|||||||
	, 6,
 | 
						, 6,
 | 
				
			||||||
	PMES, 1,        /* 15, PME_STATUS */
 | 
						PMES, 1,        /* 15, PME_STATUS */
 | 
				
			||||||
	Offset(0xC8),   /* 0xC8, TBT NVM FW Revision */
 | 
						Offset(0xC8),   /* 0xC8, TBT NVM FW Revision */
 | 
				
			||||||
	,     30,
 | 
						,     31,
 | 
				
			||||||
	IF30,  1,       /* ITBT FW Version Bit30 */
 | 
					 | 
				
			||||||
	INFR,  1,       /* TBT NVM FW Ready */
 | 
						INFR,  1,       /* TBT NVM FW Ready */
 | 
				
			||||||
	Offset(0xEC),   /* 0xEC, TBT TO PCIE Register */
 | 
						Offset(0xEC),   /* 0xEC, TBT TO PCIE Register */
 | 
				
			||||||
	TB2P, 32,       /* TBT to PCIe */
 | 
						TB2P, 32,       /* TBT to PCIe */
 | 
				
			||||||
 
 | 
				
			|||||||
		Reference in New Issue
	
	Block a user