drivers/intel/fsp2_0: remove unused fsp_load_binary()
Remove the now unused fsp_load_binary() function. BUG=chrome-os-partner:52679 Change-Id: I5667eb71689a69a9e05f7be05cb0c7e7795a55d3 Signed-off-by: Aaron Durbin <adurbin@chromium.org> Reviewed-on: https://review.coreboot.org/15743 Tested-by: build bot (Jenkins) Reviewed-by: Furquan Shaikh <furquan@google.com>
This commit is contained in:
		| @@ -16,8 +16,6 @@ | ||||
| #include <console/console.h> | ||||
| #include <fsp/util.h> | ||||
| #include <lib.h> | ||||
| #include <memrange.h> | ||||
| #include <program_loading.h> | ||||
| #include <reset.h> | ||||
| #include <string.h> | ||||
|  | ||||
| @@ -136,42 +134,6 @@ enum cb_err fsp_validate_component(struct fsp_header *hdr, | ||||
| 	return CB_SUCCESS; | ||||
| } | ||||
|  | ||||
| /* TODO: this won't work for SoC's that need to XIP certain modules. */ | ||||
| enum cb_err fsp_load_binary(struct fsp_header *hdr, | ||||
| 			    const char *name, | ||||
| 			    struct range_entry *range) | ||||
| { | ||||
| 	struct cbfsf file_desc; | ||||
| 	struct region_device file_data; | ||||
|  | ||||
| 	if (cbfs_boot_locate(&file_desc, name, NULL)) { | ||||
| 		printk(BIOS_ERR, "Could not locate %s in CBFS\n", name); | ||||
| 		return CB_ERR; | ||||
| 	} | ||||
|  | ||||
| 	cbfs_file_data(&file_data, &file_desc); | ||||
|  | ||||
| 	if (fsp_validate_component(hdr, &file_data) != CB_SUCCESS) | ||||
| 		return CB_ERR; | ||||
|  | ||||
| 	/* Check if the component load address is within expected range */ | ||||
| 	/* TODO: this doesn't check the current running program footprint. */ | ||||
| 	if (range_entry_base(range) > hdr->image_base || | ||||
| 	    range_entry_end(range) <= hdr->image_base + hdr->image_size) { | ||||
| 		printk(BIOS_ERR, "%s is outside of allowed range\n", name); | ||||
| 		return CB_ERR; | ||||
| 	} | ||||
|  | ||||
| 	/* Load binary into memory. */ | ||||
| 	if (rdev_readat(&file_data, (void *)hdr->image_base, 0, hdr->image_size) < 0) | ||||
| 		return CB_ERR; | ||||
|  | ||||
| 	/* Signal that FSP component has been loaded. */ | ||||
| 	prog_segment_loaded(hdr->image_base, hdr->image_size, SEG_FINAL); | ||||
|  | ||||
| 	return CB_SUCCESS; | ||||
| } | ||||
|  | ||||
| void fsp_handle_reset(enum fsp_status status) | ||||
| { | ||||
| 	switch(status) { | ||||
|   | ||||
		Reference in New Issue
	
	Block a user