From ec3c41a6eecd20141431d9e1103b20395bc70594 Mon Sep 17 00:00:00 2001 From: Tarun Tuli Date: Fri, 13 May 2022 15:19:40 +0000 Subject: [PATCH] soc/intel/alderlake: Fix Coverity CID 1488814 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit CID 1488814:  Uninitialized variables  (UNINIT) Commit c66ea98 introduced an issue after static analysis on merge. Because every APIC is associated with a CPU, this did not result in any issues at runtime but should be fixed/cleaned up. Now, the path name is initialized to null. Fixes: Coverity CID 1488814, commit c66ea98 TEST=Built on brya Change-Id: I0cfc8fd7a0c39e6610a9361630e3755293084f3d Signed-off-by: Tarun Tuli Reviewed-on: https://review.coreboot.org/c/coreboot/+/64336 Tested-by: build bot (Jenkins) Reviewed-by: Elyes Haouas Reviewed-by: Arthur Heymans Reviewed-by: Tim Wawrzynczak --- src/soc/intel/alderlake/acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/soc/intel/alderlake/acpi.c b/src/soc/intel/alderlake/acpi.c index b6c5699d78..e588f803c7 100644 --- a/src/soc/intel/alderlake/acpi.c +++ b/src/soc/intel/alderlake/acpi.c @@ -293,7 +293,7 @@ void soc_lpi_get_constraints(void *unused) break; case DEVICE_PATH_APIC: - char path[32]; + char path[32] = {0}; /* Lookup CPU id */ for (size_t i = 0; i < CONFIG_MAX_CPUS; i++) {