sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

acpigen: Add stop gpio control to power resource

Browse Source 
There is at least one I2C device (being used by Soraka) that has 3
controls -- enable, reset and stop. If the stop gpio is not put into
the right state when turning off the device in suspend mode, then it
causes leakage. Thus, we need control in power resource to be able to
stop the device when entering suspend state.

BUG=b:64987428
TEST=Verified on soraka that touchscreen stop is correctly configured
on suspend.

Change-Id: Iae5ec7eb3972c5c7f80956d60d0d3c321bbefb0f
Signed-off-by: Furquan Shaikh <furquan@chromium.org>
Reviewed-on: https://review.coreboot.org/21249
Reviewed-by: Duncan Laurie <dlaurie@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Furquan Shaikh
2017-08-28 17:20:49 -07:00
committed by Furquan Shaikh
parent a62520bc79
commit edf459fe65
6 changed files with 31 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/drivers/spi/acpi/acpi.c
View File

@ -168,7 +168,8 @@ static void spi_acpi_fill_ssdt_generator(struct device *dev)
if (config->has_power_resource)
acpi_device_add_power_res(
&config->reset_gpio, config->reset_delay_ms,
&config->enable_gpio, config->enable_delay_ms);
&config->enable_gpio, config->enable_delay_ms,
&config->stop_gpio, config->stop_delay_ms);
acpigen_pop_len(); /* Device */
acpigen_pop_len(); /* Scope */

5
src/drivers/spi/acpi/chip.h
View File

@ -47,6 +47,11 @@ struct drivers_spi_acpi_config {
struct acpi_gpio enable_gpio;
/* Delay to be inserted after device is enabled. */
unsigned enable_delay_ms;
/* GPIO used to stop operation of device. */
struct acpi_gpio stop_gpio;
/* Delay to be inserted after disabling stop. */
unsigned stop_delay_ms;
};
#endif /* __SPI_ACPI_CHIP_H__ */