src/*/intel/: clarify Kconfig options regarding IFD
HAVE_INTEL_FIRMWARE is used to enable certain options that rely on a valid Inter Flash Descriptor to exist. It does *not* identify platforms or boards that are capable of running in descriptor mode if it's valid. Refine the help text to make this clear. Introduce a new option INTEL_DESCRIPTOR_MODE_CAPABLE that does simply declare that IFD is supported by the platform. Select this value everywhere instead of the HAVE_INTEL_FIRMWARE and default HAVE_INTEL_FIRMWARE to y if INTEL_DESCRIPTOR_MODE_CAPABLE is selected. Move the QEMU Q35 special case (deselection of HAVE_INTEL_FIRMWARE) to the mainboard directory. Change-Id: I4791fce03982bf0443bf0b8e26d9f4f06c6f2060 Signed-off-by: Stefan Tauner <stefan.tauner@gmx.at> Reviewed-on: https://review.coreboot.org/28371 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Reviewed-by: Philipp Deppenwiese <zaolin.daisuki@gmail.com> Reviewed-by: Angel Pons <th3fanbus@gmail.com> Reviewed-by: Aaron Durbin <adurbin@chromium.org>
This commit is contained in:
committed by
Nico Huber
parent
9fc7b8e973
commit
ef8b95745f
@@ -45,7 +45,7 @@ config CPU_SPECIFIC_OPTIONS
|
||||
select COMMON_FADT
|
||||
select FSP_PLATFORM_MEMORY_SETTINGS_VERSIONS
|
||||
select GENERIC_GPIO_LIB
|
||||
select HAVE_INTEL_FIRMWARE
|
||||
select INTEL_DESCRIPTOR_MODE_CAPABLE
|
||||
select HAVE_SMI_HANDLER
|
||||
select MRC_SETTINGS_PROTECT
|
||||
select MRC_SETTINGS_VARIABLE_DATA
|
||||
|
@@ -34,7 +34,7 @@ config CPU_SPECIFIC_OPTIONS
|
||||
select TSC_SYNC_MFENCE
|
||||
select UDELAY_TSC
|
||||
select SOC_INTEL_COMMON
|
||||
select HAVE_INTEL_FIRMWARE
|
||||
select INTEL_DESCRIPTOR_MODE_CAPABLE
|
||||
select HAVE_SPI_CONSOLE_SUPPORT
|
||||
select INTEL_GMA_ACPI
|
||||
select INTEL_GMA_SWSMISCI
|
||||
|
@@ -42,7 +42,7 @@ config CPU_SPECIFIC_OPTIONS
|
||||
select TSC_SYNC_MFENCE
|
||||
select UDELAY_TSC
|
||||
select USE_GENERIC_FSP_CAR_INC
|
||||
select HAVE_INTEL_FIRMWARE
|
||||
select INTEL_DESCRIPTOR_MODE_CAPABLE
|
||||
select HAVE_SPI_CONSOLE_SUPPORT
|
||||
select HAVE_FSP_GOP
|
||||
select GENERIC_GPIO_LIB
|
||||
|
@@ -35,7 +35,7 @@ config CPU_SPECIFIC_OPTIONS
|
||||
select TSC_SYNC_MFENCE
|
||||
select UDELAY_TSC
|
||||
select SOC_INTEL_COMMON
|
||||
select HAVE_INTEL_FIRMWARE
|
||||
select INTEL_DESCRIPTOR_MODE_CAPABLE
|
||||
select SOC_INTEL_COMMON_ACPI_WAKE_SOURCE
|
||||
select HAVE_SPI_CONSOLE_SUPPORT
|
||||
select CPU_INTEL_COMMON
|
||||
|
@@ -36,7 +36,7 @@ config CPU_SPECIFIC_OPTIONS
|
||||
select GENERIC_GPIO_LIB
|
||||
select HAVE_FSP_GOP
|
||||
select HAVE_HARD_RESET
|
||||
select HAVE_INTEL_FIRMWARE
|
||||
select INTEL_DESCRIPTOR_MODE_CAPABLE
|
||||
select HAVE_MONOTONIC_TIMER
|
||||
select HAVE_SMI_HANDLER
|
||||
select IDT_IN_EVERY_STAGE
|
||||
|
@@ -43,6 +43,7 @@ config CPU_SPECIFIC_OPTIONS
|
||||
select PARALLEL_MP
|
||||
select PCR_COMMON_IOSF_1_0
|
||||
select SMP
|
||||
select INTEL_DESCRIPTOR_MODE_CAPABLE
|
||||
select SOC_INTEL_COMMON_BLOCK
|
||||
select SOC_INTEL_COMMON_BLOCK_CPU
|
||||
# select SOC_INTEL_COMMON_BLOCK_SA
|
||||
|
@@ -41,7 +41,7 @@ config CPU_SPECIFIC_OPTIONS
|
||||
select TSC_SYNC_MFENCE
|
||||
select UDELAY_TSC
|
||||
select SUPPORT_CPU_UCODE_IN_CBFS
|
||||
select HAVE_INTEL_FIRMWARE
|
||||
select INTEL_DESCRIPTOR_MODE_CAPABLE
|
||||
select HAVE_SPI_CONSOLE_SUPPORT
|
||||
|
||||
# Microcode header files are delivered in FSP package
|
||||
|
@@ -22,7 +22,7 @@ config CPU_SPECIFIC_OPTIONS
|
||||
select SUPPORT_CPU_UCODE_IN_CBFS
|
||||
# Microcode header files are delivered in FSP package
|
||||
select USES_MICROCODE_HEADER_FILES if HAVE_FSP_BIN
|
||||
select HAVE_INTEL_FIRMWARE
|
||||
select INTEL_DESCRIPTOR_MODE_CAPABLE
|
||||
select SMM_TSEG
|
||||
select HAVE_SMI_HANDLER
|
||||
select TSC_MONOTONIC_TIMER
|
||||
|
@@ -32,7 +32,7 @@ config CPU_SPECIFIC_OPTIONS
|
||||
select GENERIC_GPIO_LIB
|
||||
select HAVE_FSP_GOP
|
||||
select HAVE_HARD_RESET
|
||||
select HAVE_INTEL_FIRMWARE
|
||||
select INTEL_DESCRIPTOR_MODE_CAPABLE
|
||||
select HAVE_MONOTONIC_TIMER
|
||||
select HAVE_SMI_HANDLER
|
||||
select INTEL_GMA_ACPI
|
||||
|
Reference in New Issue
Block a user