sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

arm: libpayload: Make cache invalidation take pointers instead of integers

Browse Source 
This minor refactoring patch changes the signature of all limited cache
invalidation functions in coreboot and libpayload from unsigned long to
void * for the address argument, since that's really what you have in
95% of the cases and I think it's ugly to have casting boilerplate all
over the place.

Change-Id: Ic9d3b2ea70b6aa8aea6647adae43ee2183b4e065
Signed-off-by: Julius Werner <jwerner@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/167338
(cherry picked from commit d550bec944736dfa29fcf109e30f17a94af03576)
Signed-off-by: Isaac Christensen <isaac.christensen@se-eng.com>
Reviewed-on: http://review.coreboot.org/6623
Tested-by: build bot (Jenkins)
Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
This commit is contained in:
Julius Werner
2013-08-28 14:43:14 -07:00
committed by Marc Jones
parent 7d7eeddbbd
commit f09f2247d7
6 changed files with 24 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
payloads/libpayload/arch/armv7/cache.c
View File

@@ -34,6 +34,7 @@
#include <stdint.h>
#include <arch/cache.h>
#include <arch/virtual.h>
#define bitmask(high, low) ((1UL << (high)) + \
((1UL << (high)) - 1) - ((1UL << (low)) - 1))
@@ -213,16 +214,16 @@ static unsigned int line_bytes(void)
* perform cache maintenance on a particular memory range rather than the
* entire cache.
*/
static void dcache_op_mva(unsigned long addr,
unsigned long len, enum dcache_op op)
static void dcache_op_mva(void const *vaddr, size_t len, enum dcache_op op)
{
unsigned long line, linesize;
unsigned long paddr = virt_to_phys(vaddr);
linesize = line_bytes();
line = addr & ~(linesize - 1);
line = paddr & ~(linesize - 1);
dsb();
while (line < addr + len) {
while (line < paddr + len) {
switch(op) {
case OP_DCCIMVAC:
dccimvac(line);
@@ -241,17 +242,17 @@ static void dcache_op_mva(unsigned long addr,
isb();
}
void dcache_clean_by_mva(unsigned long addr, unsigned long len)
void dcache_clean_by_mva(void const *addr, size_t len)
{
dcache_op_mva(addr, len, OP_DCCMVAC);
}
void dcache_clean_invalidate_by_mva(unsigned long addr, unsigned long len)
void dcache_clean_invalidate_by_mva(void const *addr, size_t len)
{
dcache_op_mva(addr, len, OP_DCCIMVAC);
}
void dcache_invalidate_by_mva(unsigned long addr, unsigned long len)
void dcache_invalidate_by_mva(void const *addr, size_t len)
{
dcache_op_mva(addr, len, OP_DCIMVAC);
}