sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drivers/intel/fsp2_0: Remove x64-specific assertion from fsp_header

Browse Source 
Same fsp_header struture is being used for x64 and x32 modes
and hence dropping the x64 assertion.

BUG=b:329034258
TEST=Verified on Meteor Lake board (Rex)

Change-Id: I6013af342670e6377a3fe7641d7d9b52c9b6f57c
Signed-off-by: Appukuttan V K <appukuttan.vk@intel.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/81662
Reviewed-by: Subrata Banik <subratabanik@google.com>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-by: Usha P <usha.p@intel.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Appukuttan V K
2024-04-03 23:06:26 +05:30
committed by Subrata Banik
parent a63ce30c93
commit f09fcd6fef
1 changed files with 0 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/drivers/intel/fsp2_0/include/fsp/info_header.h
View File

@@ -12,7 +12,6 @@
#define FSP_HDR_ATTRIB_FSPS 3
#define FSP_IMAGE_ID_LENGTH 8
#if CONFIG(PLATFORM_USES_FSP2_X86_32)
struct fsp_header {
uint32_t signature; //FSPH
uint32_t header_length;
@@ -40,9 +39,6 @@ struct fsp_header {
uint32_t fsp_multi_phase_mem_init_entry_offset;
uint32_t res5;
} __packed;
#else
#error You need to implement this struct for x86_64 FSP
#endif
enum cb_err fsp_identify(struct fsp_header *hdr, const void *fsp_blob);