sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/intel/tglrvp/dt: Make use of device alias names

Browse Source 
Also, remove superfluous comments from devices which repeat their name.

Change-Id: I009330042b59c9e6e78aa6f3819546b771b26ff0
Signed-off-by: Felix Singer <felixsinger@posteo.net>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/83244
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
This commit is contained in:
Felix Singer
2024-06-27 21:09:11 +02:00
parent 9a12acf1e3
commit f13284cedb
2 changed files with 142 additions and 145 deletions
Download Patch File Download Diff File Expand all files Collapse all files

144
src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb
View File

@@ -162,10 +162,9 @@ chip soc/intel/tigerlake
}" }"
device domain 0 on device domain 0 on
#From EDS(575683) device ref system_agent on end
device pci 00.0 on end # Host Bridge 0x9A14:U/0x9A12:Y device ref igpu on end
device pci 02.0 on end # Graphics device ref dptf on
device pci 04.0 on
# Default DPTF Policy for all tglrvp_up3 boards if not overridden # Default DPTF Policy for all tglrvp_up3 boards if not overridden
chip drivers/intel/dptf chip drivers/intel/dptf
register "policies.passive[0]" = "DPTF_PASSIVE(CPU, CPU, 95, 1000)" register "policies.passive[0]" = "DPTF_PASSIVE(CPU, CPU, 95, 1000)"
@@ -186,45 +185,44 @@ chip soc/intel/tigerlake
.granularity = 1000,}" .granularity = 1000,}"
device generic 0 on end device generic 0 on end
end end
end # DPTF 0x9A04:U22/0x9A14:U42 end
device pci 05.0 on end # IPU 0x9A19 device ref ipu on end
device pci 06.0 on end # PEG60 0x9A09 device ref peg on end
device pci 07.0 on end # TBT_PCIe0 0x9A23 device ref tbt_pcie_rp0 on end
device pci 07.1 on end # TBT_PCIe1 0x9A25 device ref tbt_pcie_rp1 on end
device pci 07.2 on end # TBT_PCIe2 0x9A27 device ref tbt_pcie_rp2 on end
device pci 07.3 on end # TBT_PCIe3 0x9A29 device ref tbt_pcie_rp3 on end
device pci 08.0 off end # GNA 0x9A11 device ref gna off end
device pci 09.0 off end # NPK 0x9A33 device ref npk off end
device pci 0a.0 off end # Crash-log SRAM 0x9A0D device ref crashlog off end
device pci 0d.0 on end # USB xHCI 0x9A13 device ref north_xhci on end
device pci 0d.1 on end # USB xDCI (OTG) 0x9A15 device ref north_xdci on end
device pci 0d.2 on end # TBT DMA0 0x9A1B device ref tbt_dma0 on end
device pci 0d.3 on end # TBT DMA1 0x9A1D device ref tbt_dma1 on end
device pci 0e.0 off end # VMD 0x9A0B device ref vmd off end
# From PCH EDS(576591) device ref thc0 off end
device pci 10.6 off end # THC0 0xA0D0 device ref thc1 off end
device pci 10.7 off end # THC1 0xA0D1 device ref ish on
device pci 12.0 on # SensorHUB 0xA0FC
chip drivers/intel/ish chip drivers/intel/ish
register "firmware_name" = ""tglrvp_ish.bin"" register "firmware_name" = ""tglrvp_ish.bin""
device generic 0 on end device generic 0 on end
end end
end end
device pci 12.6 off end # GSPI2 0x34FB device ref gspi2 off end
device pci 13.0 off end # GSPI3 0xA0FD device ref gspi3 off end
device pci 14.0 on end # USB3.1 xHCI 0xA0ED device ref south_xhci on end
device pci 14.1 on end # USB3.1 xDCI 0xA0EE device ref south_xdci on end
device pci 14.2 on end # Shared RAM 0xA0EF device ref shared_ram on end
device pci 14.3 on device ref cnvi_wifi on
chip drivers/wifi/generic chip drivers/wifi/generic
register "wake" = "GPE0_PME_B0" register "wake" = "GPE0_PME_B0"
device generic 0 on end device generic 0 on end
end end
end # CNVi: WiFi 0xA0F0 - A0F3 end
device pci 15.0 on # I2C0 0xA0E8 device ref i2c0 on
chip drivers/i2c/generic chip drivers/i2c/generic
register "hid" = ""10EC1308"" register "hid" = ""10EC1308""
register "name" = ""RTAM"" register "name" = ""RTAM""
@@ -259,58 +257,58 @@ chip soc/intel/tigerlake
register "property_list[0].integer" = "1" register "property_list[0].integer" = "1"
device i2c 1a on end device i2c 1a on end
end end
end # I2C0 end
device pci 15.1 on end # I2C1 0xA0E9 device ref i2c1 on end
device pci 15.2 on end # I2C2 0xA0EA device ref i2c2 on end
device pci 15.3 on end # I2C3 0xA0EB device ref i2c3 on end
device pci 16.0 on end # HECI1 0xA0E0 device ref heci1 on end
device pci 16.1 off end # HECI2 0xA0E1 device ref heci2 off end
device pci 16.2 off end # CSME 0xA0E2 device ref csme1 off end
device pci 16.3 off end # CSME 0xA0E3 device ref csme2 off end
device pci 16.4 off end # HECI3 0xA0E4 device ref heci3 off end
device pci 16.5 off end # HECI4 0xA0E5 device ref heci4 off end
device pci 17.0 on end # SATA 0xA0D3 device ref sata on end
device pci 19.0 off end # I2C4 0xA0C5 device ref i2c4 off end
device pci 19.1 on end # I2C5 0xA0C6 device ref i2c5 on end
device pci 19.2 on end # UART2 0xA0C7 device ref uart2 on end
device pci 1c.0 off end # RP1 0xA0B8 device ref pcie_rp1 off end
device pci 1c.1 off end # RP2 0xA0B9 device ref pcie_rp2 off end
device pci 1c.2 on end # RP3 0xA0BA device ref pcie_rp3 on end
device pci 1c.3 on device ref pcie_rp4 on
chip soc/intel/common/block/pcie/rtd3 chip soc/intel/common/block/pcie/rtd3
register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_B17)" register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_B17)"
register "srcclk_pin" = "2" register "srcclk_pin" = "2"
device generic 0 on end device generic 0 on end
end end
end # RP4 0xA0BB end
device pci 1c.4 off end # RP5 0xA0BC device ref pcie_rp5 off end
device pci 1c.5 off end # RP6 0xA0BD device ref pcie_rp6 off end
device pci 1c.6 off end # RP7 0xA0BE device ref pcie_rp7 off end
device pci 1c.7 off end # RP8 0xA0BF device ref pcie_rp8 off end
device pci 1d.0 on end # RP9 0xA0B0 device ref pcie_rp9 on end
device pci 1d.1 off end # RP10 0xA0B1 device ref pcie_rp10 off end
device pci 1d.2 on end # RP11 0xA0B2 device ref pcie_rp11 on end
device pci 1d.3 off end # RP12 0xA0B3 device ref pcie_rp12 off end
device pci 1e.0 off end # UART0 0xA0A8 device ref uart0 off end
device pci 1e.1 off end # UART1 0xA0A9 device ref uart1 off end
device pci 1e.2 on end # GSPI0 0xA0AA device ref gspi0 on end
device pci 1e.3 on device ref gspi1 on
chip drivers/spi/acpi chip drivers/spi/acpi
register "hid" = "ACPI_DT_NAMESPACE_HID" register "hid" = "ACPI_DT_NAMESPACE_HID"
register "compat_string" = ""google,cr50"" register "compat_string" = ""google,cr50""
register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_C22_IRQ)" register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_C22_IRQ)"
device spi 0 on end device spi 0 on end
end end
end # GSPI1 0xA0AB end
device pci 1f.0 on device ref pch_espi on
chip ec/google/chromeec chip ec/google/chromeec
use conn0 as mux_conn[0] use conn0 as mux_conn[0]
use conn1 as mux_conn[1] use conn1 as mux_conn[1]
device pnp 0c09.0 on end device pnp 0c09.0 on end
end end
end # eSPI 0xA080 - A09F end
device pci 1f.1 on end # P2SB 0xA0A0 device ref p2sb on end
device pci 1f.2 hidden # PMC 0xA0A1 device ref pmc hidden
# The pmc_mux chip driver is a placeholder for the # The pmc_mux chip driver is a placeholder for the
# PMC.MUX device in the ACPI hierarchy. # PMC.MUX device in the ACPI hierarchy.
chip drivers/intel/pmc_mux chip drivers/intel/pmc_mux
@@ -331,11 +329,11 @@ chip soc/intel/tigerlake
end end
end end
end end
end # PMC end
device pci 1f.3 on end # Intel HD audio 0xA0C8-A0CF device ref hda on end
device pci 1f.4 on end # SMBus 0xA0A3 device ref smbus on end
device pci 1f.5 on end # SPI 0xA0A4 device ref fast_spi on end
device pci 1f.6 off end # GbE 0x15E1/0x15E2 device ref gbe off end
device pci 1f.7 off end # TH 0xA0A6 device ref tracehub off end
end end
end end

143
src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb
View File

@@ -167,9 +167,9 @@ chip soc/intel/tigerlake
device domain 0 on device domain 0 on
#From EDS(575683) #From EDS(575683)
device pci 00.0 on end # Host Bridge 0x9A14:U/0x9A12:Y device ref system_agent on end
device pci 02.0 on end # Graphics device ref igpu on end
device pci 04.0 on device ref dptf on
# Default DPTF Policy for all tglrvp_up4 boards if not overridden # Default DPTF Policy for all tglrvp_up4 boards if not overridden
chip drivers/intel/dptf chip drivers/intel/dptf
register "policies.passive[0]" = "DPTF_PASSIVE(CPU, CPU, 95, 1000)" register "policies.passive[0]" = "DPTF_PASSIVE(CPU, CPU, 95, 1000)"
@@ -190,45 +190,44 @@ chip soc/intel/tigerlake
.granularity = 1000,}" .granularity = 1000,}"
device generic 0 on end device generic 0 on end
end end
end # DPTF 0x9A02:Y22/0x9A12:Y42 end
device pci 05.0 on end # IPU 0x9A19 device ref ipu on end
device pci 06.0 on end # PEG60 0x9A09 device ref peg on end
device pci 07.0 on end # TBT_PCIe0 0x9A23 device ref tbt_pcie_rp0 on end
device pci 07.1 on end # TBT_PCIe1 0x9A25 device ref tbt_pcie_rp1 on end
device pci 07.2 on end # TBT_PCIe2 0x9A27 device ref tbt_pcie_rp2 on end
device pci 07.3 off end # TBT_PCIe3 0x9A29 device ref tbt_pcie_rp3 off end
device pci 08.0 off end # GNA 0x9A11 device ref gna off end
device pci 09.0 off end # NPK 0x9A33 device ref npk off end
device pci 0a.0 off end # Crash-log SRAM 0x9A0D device ref crashlog off end
device pci 0d.0 on end # USB xHCI 0x9A13 device ref north_xhci on end
device pci 0d.1 on end # USB xDCI (OTG) 0x9A15 device ref north_xdci on end
device pci 0d.2 on end # TBT DMA0 0x9A1B device ref tbt_dma0 on end
device pci 0d.3 on end # TBT DMA1 0x9A1D device ref tbt_dma1 on end
device pci 0e.0 off end # VMD 0x9A0B device ref vmd off end
# From PCH EDS(576591) device ref thc0 off end
device pci 10.6 off end # THC0 0xA0D0 device ref thc1 off end
device pci 10.7 off end # THC1 0xA0D1 device ref ish on
device pci 12.0 on # SensorHUB 0xA0FC
chip drivers/intel/ish chip drivers/intel/ish
register "firmware_name" = ""tglrvp_ish.bin"" register "firmware_name" = ""tglrvp_ish.bin""
device generic 0 on end device generic 0 on end
end end
end end
device pci 12.6 off end # GSPI2 0x34FB device ref gspi2 off end
device pci 13.0 off end # GSPI3 0xA0FD device ref gspi3 off end
device pci 14.0 on end # USB3.1 xHCI 0xA0ED device ref south_xhci on end
device pci 14.1 on end # USB3.1 xDCI 0xA0EE device ref south_xdci on end
device pci 14.2 on end # Shared RAM 0xA0EF device ref shared_ram on end
device pci 14.3 on device ref cnvi_wifi on
chip drivers/wifi/generic chip drivers/wifi/generic
register "wake" = "GPE0_PME_B0" register "wake" = "GPE0_PME_B0"
device generic 0 on end device generic 0 on end
end end
end # CNVi: WiFi 0xA0F0 - A0F3 end
device pci 15.0 on # I2C0 0xA0E8 device ref i2c0 on
chip drivers/i2c/generic chip drivers/i2c/generic
register "hid" = ""10EC1308"" register "hid" = ""10EC1308""
register "name" = ""RTAM"" register "name" = ""RTAM""
@@ -263,58 +262,58 @@ chip soc/intel/tigerlake
register "property_list[0].integer" = "1" register "property_list[0].integer" = "1"
device i2c 1a on end device i2c 1a on end
end end
end # I2C0 end
device pci 15.1 on end # I2C1 0xA0E9 device ref i2c1 on end
device pci 15.2 on end # I2C2 0xA0EA device ref i2c2 on end
device pci 15.3 on end # I2C3 0xA0EB device ref i2c3 on end
device pci 16.0 on end # HECI1 0xA0E0 device ref heci1 on end
device pci 16.1 off end # HECI2 0xA0E1 device ref heci2 off end
device pci 16.2 off end # CSME 0xA0E2 device ref csme1 off end
device pci 16.3 off end # CSME 0xA0E3 device ref csme2 off end
device pci 16.4 off end # HECI3 0xA0E4 device ref heci3 off end
device pci 16.5 off end # HECI4 0xA0E5 device ref heci4 off end
device pci 17.0 on end # SATA 0xA0D3 device ref sata on end
device pci 19.0 off end # I2C4 0xA0C5 device ref i2c4 off end
device pci 19.1 on end # I2C5 0xA0C6 device ref i2c5 on end
device pci 19.2 on end # UART2 0xA0C7 device ref uart2 on end
device pci 1c.0 off end # RP1 0xA0B8 device ref pcie_rp1 off end
device pci 1c.1 off end # RP2 0xA0B9 device ref pcie_rp2 off end
device pci 1c.2 on end # RP3 0xA0BA device ref pcie_rp3 on end
device pci 1c.3 on device ref pcie_rp4 on
chip soc/intel/common/block/pcie/rtd3 chip soc/intel/common/block/pcie/rtd3
register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_B17)" register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_B17)"
register "srcclk_pin" = "2" register "srcclk_pin" = "2"
device generic 0 on end device generic 0 on end
end end
end # RP4 0xA0BB end
device pci 1c.4 off end # RP5 0xA0BC device ref pcie_rp5 off end
device pci 1c.5 off end # RP6 0xA0BD device ref pcie_rp6 off end
device pci 1c.6 off end # RP7 0xA0BE device ref pcie_rp7 off end
device pci 1c.7 off end # RP8 0xA0BF device ref pcie_rp8 off end
device pci 1d.0 on end # RP9 0xA0B0 device ref pcie_rp9 on end
device pci 1d.1 off end # RP10 0xA0B1 device ref pcie_rp10 off end
device pci 1d.2 on end # RP11 0xA0B2 device ref pcie_rp11 on end
device pci 1d.3 off end # RP12 0xA0B3 device ref pcie_rp12 off end
device pci 1e.0 off end # UART0 0xA0A8 device ref uart0 off end
device pci 1e.1 off end # UART1 0xA0A9 device ref uart1 off end
device pci 1e.2 on end # GSPI0 0xA0AA device ref gspi0 on end
device pci 1e.3 on device ref gspi1 on
chip drivers/spi/acpi chip drivers/spi/acpi
register "hid" = "ACPI_DT_NAMESPACE_HID" register "hid" = "ACPI_DT_NAMESPACE_HID"
register "compat_string" = ""google,cr50"" register "compat_string" = ""google,cr50""
register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_C22_IRQ)" register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_C22_IRQ)"
device spi 0 on end device spi 0 on end
end end
end # GSPI1 0xA0AB end
device pci 1f.0 on device ref pch_espi on
chip ec/google/chromeec chip ec/google/chromeec
use conn0 as mux_conn[0] use conn0 as mux_conn[0]
use conn1 as mux_conn[1] use conn1 as mux_conn[1]
device pnp 0c09.0 on end device pnp 0c09.0 on end
end end
end # eSPI 0xA080 - A09F end
device pci 1f.1 on end # P2SB 0xA0A0 device ref p2sb on end
device pci 1f.2 hidden # PMC 0xA0A1 device ref pmc hidden
# The pmc_mux chip driver is a placeholder for the # The pmc_mux chip driver is a placeholder for the
# PMC.MUX device in the ACPI hierarchy. # PMC.MUX device in the ACPI hierarchy.
chip drivers/intel/pmc_mux chip drivers/intel/pmc_mux
@@ -335,11 +334,11 @@ chip soc/intel/tigerlake
end end
end end
end end
end # PMC end
device pci 1f.3 on end # Intel HD audio 0xA0C8-A0CF device ref hda on end
device pci 1f.4 on end # SMBus 0xA0A3 device ref smbus on end
device pci 1f.5 on end # SPI 0xA0A4 device ref fast_spi on end
device pci 1f.6 off end # GbE 0x15E1/0x15E2 device ref gbe off end
device pci 1f.7 off end # TH 0xA0A6 device ref tracehub off end
end end
end end