sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/intel/archercity_crb: Fix build for specific configurations

Browse Source 
Guard OCP functions calls to allow builds without OCP drivers.

Change-Id: Ie9a82387366a8bb3387bcba3ec7a4c7f0100f78c
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/82168
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Lean Sheng Tan <sheng.tan@9elements.com>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Patrick Rudolph 2024-04-19 09:05:04 +02:00 committed by Felix Held
parent 1f199f283d
commit f2ac23fb13
2 changed files with 18 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
src/mainboard/intel/archercity_crb/romstage.c
View File

@ -11,7 +11,8 @@
void mainboard_ewl_check(void) void mainboard_ewl_check(void)
{ {
get_ewl(); if (CONFIG(OCP_EWL))
get_ewl();
} }
static void mainboard_config_iio(FSPM_UPD *mupd) static void mainboard_config_iio(FSPM_UPD *mupd)
@ -36,21 +37,23 @@ static void mainboard_config_iio(FSPM_UPD *mupd)
void mainboard_memory_init_params(FSPM_UPD *mupd) void mainboard_memory_init_params(FSPM_UPD *mupd)
{ {
/* Setup FSP log */ /* Setup FSP log */
mupd->FspmConfig.SerialIoUartDebugEnable = get_bool_from_vpd(FSP_LOG, if (CONFIG(OCP_VPD)) {
FSP_LOG_DEFAULT); mupd->FspmConfig.SerialIoUartDebugEnable = get_bool_from_vpd(FSP_LOG,
if (mupd->FspmConfig.SerialIoUartDebugEnable) { FSP_LOG_DEFAULT);
mupd->FspmConfig.serialDebugMsgLvl = get_int_from_vpd_range( if (mupd->FspmConfig.SerialIoUartDebugEnable) {
FSP_MEM_LOG_LEVEL, FSP_MEM_LOG_LEVEL_DEFAULT, 0, 4); mupd->FspmConfig.serialDebugMsgLvl = get_int_from_vpd_range(
/* If serialDebugMsgLvl less than 1, disable FSP memory train results */ FSP_MEM_LOG_LEVEL, FSP_MEM_LOG_LEVEL_DEFAULT, 0, 4);
if (mupd->FspmConfig.serialDebugMsgLvl <= 1) { /* If serialDebugMsgLvl less than 1, disable FSP memory train results */
printk(BIOS_DEBUG, "Setting serialDebugMsgLvlTrainResults to 0\n"); if (mupd->FspmConfig.serialDebugMsgLvl <= 1) {
mupd->FspmConfig.serialDebugMsgLvlTrainResults = 0x0; printk(BIOS_DEBUG, "Setting serialDebugMsgLvlTrainResults to 0\n");
mupd->FspmConfig.serialDebugMsgLvlTrainResults = 0x0;
}
} }
}
/* FSP Dfx PMIC Secure mode */ /* FSP Dfx PMIC Secure mode */
mupd->FspmConfig.DfxPmicSecureMode = get_int_from_vpd_range( mupd->FspmConfig.DfxPmicSecureMode = get_int_from_vpd_range(
FSP_PMIC_SECURE_MODE, FSP_PMIC_SECURE_MODE_DEFAULT, 0, 2); FSP_PMIC_SECURE_MODE, FSP_PMIC_SECURE_MODE_DEFAULT, 0, 2);
}
/* Set Rank Margin Tool to disable. */ /* Set Rank Margin Tool to disable. */
mupd->FspmConfig.EnableRMT = 0x0; mupd->FspmConfig.EnableRMT = 0x0;

2
src/mainboard/intel/archercity_crb/util.c
View File

@ -4,7 +4,7 @@
#include <soc/chip_common.h> #include <soc/chip_common.h>
#include <soc/util.h> #include <soc/util.h>
#if CONFIG(SOC_INTEL_HAS_CXL) #if CONFIG(SOC_INTEL_HAS_CXL) && CONFIG(OCP_VPD)
enum xeonsp_cxl_mode get_cxl_mode(void) enum xeonsp_cxl_mode get_cxl_mode(void)
{ {
int ocp_cxl_mode = get_cxl_mode_from_vpd(); int ocp_cxl_mode = get_cxl_mode_from_vpd();