From f339190d071dbe3aea3b62daec0d8485701f6d27 Mon Sep 17 00:00:00 2001 From: Tim Crawford Date: Tue, 26 Sep 2023 18:30:10 -0600 Subject: [PATCH] util/docker: Fix setting SDK_VERSION The `SDK_VERSION` was incorrectly set to itself instead of keeping the `COREBOOT_IMAGE_TAG` variable, leaving it as an empty string. Test: Run `make coreboot-sdk` and see `SDK_VERSION` matches the tag. Fixes: d3a89cdb749a ("util/docker: Replace use of sed with build args") Change-Id: I4c8be7d0f7c1ac82da397e720d13a7075f22ec4d Signed-off-by: Tim Crawford Reviewed-on: https://review.coreboot.org/c/coreboot/+/78141 Tested-by: build bot (Jenkins) Reviewed-by: Felix Singer Reviewed-by: Martin L Roth --- util/docker/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/docker/Makefile b/util/docker/Makefile index ca274b7143..77526bba5e 100644 --- a/util/docker/Makefile +++ b/util/docker/Makefile @@ -44,7 +44,7 @@ coreboot-sdk: test-docker @echo "Building coreboot SDK $(crossgcc_version) from commit $(DOCKER_COMMIT)" $(DOCKER) build \ --tag coreboot/coreboot-sdk:$(COREBOOT_IMAGE_TAG) \ - --build-arg=SDK_VERSION="$(SDK_VERSION)" \ + --build-arg=SDK_VERSION="$(COREBOOT_IMAGE_TAG)" \ --build-arg=DOCKER_COMMIT="$(DOCKER_COMMIT)" \ --build-arg=CROSSGCC_PARAM="$(COREBOOT_CROSSGCC_PARAM)" \ coreboot-sdk