sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nb/via/vx900: Remove some __SIMPLE_DEVICE__ use

Browse Source 
Change-Id: I840131f91e79c740c0c8784c252723ae90ded458
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/35647
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
This commit is contained in:
Kyösti Mälkki
2019-09-27 16:54:44 +03:00
parent 13ad740701
commit f485d91141
4 changed files with 3 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/northbridge/via/vx900/chrome9hd.c
View File

@@ -240,7 +240,7 @@ static void chrome9hd_init(struct device *dev)
printk(BIOS_DEBUG, "Enable VGA console\n"); printk(BIOS_DEBUG, "Enable VGA console\n");
dump_pci_device(dev); dump_pci_device(PCI_BDF(dev));
} }
static void chrome9hd_enable(struct device *dev) static void chrome9hd_enable(struct device *dev)

2
src/northbridge/via/vx900/lpc.c
View File

@@ -180,7 +180,7 @@ static void vx900_lpc_init(struct device *dev)
{ {
vx900_lpc_interrupt_stuff(dev); vx900_lpc_interrupt_stuff(dev);
vx900_lpc_misc_stuff(dev); vx900_lpc_misc_stuff(dev);
dump_pci_device(dev); dump_pci_device(PCI_BDF(dev));
} }
static void vx900_lpc_read_resources(struct device *dev) static void vx900_lpc_read_resources(struct device *dev)

6
src/northbridge/via/vx900/pci_util.c
View File

@@ -19,11 +19,7 @@
#include "vx900.h" #include "vx900.h"
#ifdef __SIMPLE_DEVICE__
void dump_pci_device(pci_devfn_t dev) void dump_pci_device(pci_devfn_t dev)
#else
void dump_pci_device(struct device *dev)
#endif
{ {
int i; int i;
for (i = 0; i <= 0xff; i++) { for (i = 0; i <= 0xff; i++) {
@@ -34,7 +30,7 @@ void dump_pci_device(struct device *dev)
if ((i & 0x0f) == 0x08) if ((i & 0x0f) == 0x08)
printk(BIOS_DEBUG, " |"); printk(BIOS_DEBUG, " |");
val = pci_read_config8(dev, i); val = pci_s_read_config8(dev, i);
printk(BIOS_DEBUG, " %.2x", val); printk(BIOS_DEBUG, " %.2x", val);
if ((i & 0x0f) == 0x0f) if ((i & 0x0f) == 0x0f)

4
src/northbridge/via/vx900/vx900.h
View File

@@ -39,10 +39,6 @@ uint64_t get_uma_memory_base(void);
/* We use these throughout the code. They really belong in a generic part of /* We use these throughout the code. They really belong in a generic part of
* coreboot, but until bureaucracy gets them there, we still need them */ * coreboot, but until bureaucracy gets them there, we still need them */
#ifdef __SIMPLE_DEVICE__
void dump_pci_device(pci_devfn_t dev); void dump_pci_device(pci_devfn_t dev);
#else
void dump_pci_device(struct device *dev);
#endif
#endif /* __VX900_H */ #endif /* __VX900_H */