sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

clean-up: Remove the no more necessary ENV_HAS_DATA_SECTION flag

Browse Source 
With commit b7832de026 ("x86: Add .data
section support for pre-memory stages"), the `ENV_HAS_DATA_SECTION'
flag and its derivatives can now be removed from the code.

Change-Id: Ic0afac76264a9bd4a9c93ca35c90bd84e9b747a2
Signed-off-by: Jeremy Compostella <jeremy.compostella@intel.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/77291
Reviewed-by: Julius Werner <jwerner@chromium.org>
Reviewed-by: Maximilian Brune <maximilian.brune@9elements.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Jeremy Compostella
2023-09-06 10:57:56 -07:00
committed by Felix Held
parent 4712f5d560
commit f65ae7490a
14 changed files with 10 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/ec/acpi/ec.c
View File

@@ -147,9 +147,6 @@ void ec_clr_bit(u8 addr, u8 bit)
void ec_set_ports(u16 cmd_reg, u16 data_reg)
{
if (!ENV_HAS_DATA_SECTION)
return;
ec_cmd_reg = cmd_reg;
ec_data_reg = data_reg;
}

2
src/ec/google/chromeec/ec_boardid.c
View File

@@ -5,7 +5,7 @@
uint32_t board_id(void)
{
MAYBE_STATIC_NONZERO uint32_t id = BOARD_ID_INIT;
static uint32_t id = BOARD_ID_INIT;
if (id == BOARD_ID_INIT) {
if (google_chromeec_get_board_version(&id))

2
src/ec/google/chromeec/ec_skuid.c
View File

@@ -5,7 +5,7 @@
uint32_t google_chromeec_get_board_sku(void)
{
MAYBE_STATIC_NONZERO uint32_t sku_id = CROS_SKU_UNKNOWN;
static uint32_t sku_id = CROS_SKU_UNKNOWN;
if (sku_id != CROS_SKU_UNKNOWN)
return sku_id;

2
src/ec/google/wilco/boardid.c
View File

@@ -5,7 +5,7 @@
uint32_t board_id(void)
{
MAYBE_STATIC_NONZERO uint32_t id = BOARD_ID_INIT;
static uint32_t id = BOARD_ID_INIT;
if (id == BOARD_ID_INIT) {
uint8_t ec_id;

2
src/ec/intel/board_id.c
View File

@@ -19,7 +19,7 @@ static uint32_t get_board_id_via_ext_ec(void)
/* Get Board ID via EC I/O port write/read */
int get_rvp_board_id(void)
{
MAYBE_STATIC_NONZERO int id = BOARD_ID_UNKNOWN;
static int id = BOARD_ID_UNKNOWN;
if (CONFIG(EC_GOOGLE_CHROMEEC)) { /* CHROME_EC */
id = get_board_id_via_ext_ec();