sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

intel: Use CF9 reset (part 2)

Browse Source 
Make use of the common CF9 reset in SOC_INTEL_COMMON_RESET. Also
implement board_reset() as a "full reset" (aka. cold reset) as that
is what was used here for hard_reset().

Drop soc_reset_prepare() thereby, as it was only used for APL. Also,
move the global-reset logic.

We leave some comments to remind us that a system_reset() should
be enough, where a full_reset() is called now (to retain current
behaviour) and looks suspicious.

Note, as no global_reset() is implemented for Denverton-NS, we halt
there now instead of issuing a non-global reset. This seems safer;
a non-global reset might result in a reset loop.

Change-Id: I5e7025c3c9ea6ded18e72037412b60a1df31bd53
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/29169
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
This commit is contained in:
Patrick Rudolph
2018-10-01 19:17:11 +02:00
committed by Patrick Georgi
parent 45022ae056
commit f677d17ab3
23 changed files with 67 additions and 92 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/lib/reset.c
View File

@ -51,24 +51,11 @@ __noreturn static void __hard_reset(void) {
}
/* Not all platforms implement all reset types. Fall back to hard_reset. */
__weak void do_global_reset(void) { __hard_reset(); }
__weak void do_soft_reset(void) { __hard_reset(); }
__weak void soc_reset_prepare(enum reset_type rt) { /* no-op */ }
void global_reset(void)
{
printk(BIOS_INFO, "%s() called!\n", __func__);
soc_reset_prepare(GLOBAL_RESET);
dcache_clean_all();
do_global_reset();
halt();
}
void hard_reset(void)
{
printk(BIOS_INFO, "%s() called!\n", __func__);
soc_reset_prepare(HARD_RESET);
dcache_clean_all();
__hard_reset();
}
@ -76,7 +63,6 @@ void hard_reset(void)
void soft_reset(void)
{
printk(BIOS_INFO, "%s() called!\n", __func__);
soc_reset_prepare(SOFT_RESET);
dcache_clean_all();
do_soft_reset();
halt();